Move com_menus modals to Bootstrap by dgrammatiko · Pull Request #4661 · joomla/joomla-cms

dgrammatiko · 2014-10-13T20:18:56Z

This is a repost of #4562 which was ruined in the rebase...

Move modals from mootools to Bootstrap

This is the last (I hope) PR to get all back end using bootstrap modals. The rest are: #4513 #4514 #4561.

Testing:

Apply patch and follow the images below to see where you should focus:

administrator/index.php?option=com_menus&view=menus

administrator/index.php?option=com_menus&view=item&layout=edit&id=101

———————

tairedweb · 2014-10-17T03:59:44Z

i follow at this step...

but when i click on breakcum... this popup said wrong at tile name.

and sometime when i'm click other position, it auto turn back...

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4661.

trangredweb · 2014-10-17T04:06:30Z

When choose Module Assignment, when click module Main Menu, it turn back main : Edit Menu Item.

When choose module "Similar Items (Public in )" in Module Assignment, popup don't show right module.

jcata · 2014-10-17T08:30:25Z

I have the same trouble that trangredweb, When I choose module like "breadcrumbs" in module assigment, popup don't show right module, and when I close this modal and choose another module go back (closing modal and select details tab).

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4661.

mrunalpittalia · 2014-10-17T09:45:55Z

I have tested this patch, fasing same issue mentioned by trangredweb & jcata .

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4661.

LLNet · 2014-10-17T11:29:19Z

The first error here.
and hey @trangredweb xD

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4661.

dgrammatiko · 2014-10-17T11:49:14Z

@LLNet @mrunalpittalia @jcata @trangredweb I fixed the rendering the wrong module problem, can you test again?

Mind you that the styling might be off here because, this PR is part of all the others with the modals, but this one NOW will use the standard css, which of course will be too narrow. you can copy/paste the template.css from here https://github.com/joomla/joomla-cms/pull/4561/files

RamaniBhadresh · 2014-10-17T12:10:47Z

@test successfully

Step1 :- Access Comoponent menus like in url (?option=com_menus&view=menus).
Step2 :- select Linked Modules->modules(DropDown)->main menu(public in position 7) before press ctrl+shift+m.
Step3 :- if u press above shortcut then layout come as bootstrape or mobile layout
Step4 :- Then after select Step2.....

So test Successful and i cant find any bugs related to bootstreps...

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4661.

anibalsanchez · 2014-10-17T12:47:08Z

@test successfully, BUT, Step1 :- Access Comoponent menus like in url (?option=com_menus&view=menus).

Notice: Undefined property: MenusViewMenus::$id in /home/pwork02/9_Testing/j3/administrator/components/com_menus/views/menus/tmpl/default.php on line 32

Generates this Javascript function "function jSelectPosition_(name) {", note that the ID is missing

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4661.

dgrammatiko · 2014-10-17T12:51:50Z

@anibalsanchez That code was already there. I’ll see what I can do

mrunalpittalia · 2014-10-17T12:56:24Z

@test Works successfully with new pull, tested successfully.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4661.

TasolJaySoni · 2014-10-17T13:01:03Z

@test sucessfully works with bootstrap without any issue..

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4661.

dgrammatiko · 2014-10-17T13:14:37Z

@anibalsanchez no notice anymore!

mrunalpittalia · 2014-10-17T13:54:51Z

Moving to RTC as we have more than 2 successful tests

Note: counted successful test after new patch from dgt41

dgrammatiko · 2014-11-06T14:55:05Z

@Bakual Did I just kill travis?

infograf768 · 2014-11-06T14:56:21Z

Relaunched it. Let's see.

Bakual · 2014-11-06T15:03:32Z

Travis kills itself nowadays 😄
There is an issue with Travis authenticating against GitHub for some reason. Looks like some rate limiting to me.
It happens now because part of Joomla is now powered using composer.

infograf768 · 2014-11-06T15:21:16Z

tested: I get
( ! ) Parse error: syntax error, unexpected end of file in root/administrator/components/com_menus/views/menus/tmpl/default.php on line 205

as a <?php endif; ?> is missing after </table>
also in this file, please respect indentation.
also
Notice: Undefined variable: canEdit in /root/administrator/components/com_menus/views/menus/tmpl/default.php on line 39

infograf768 · 2014-11-06T15:23:32Z

Also, I can't access to the Note field at bottom right of the modal, except if I enlarge drastically the window height

infograf768 · 2014-11-06T15:29:20Z

Also
( ! ) Notice: Undefined variable: item in ROOT/administrator/components/com_menus/views/item/tmpl/edit_modules.php on line 17

dgrammatiko · 2014-11-06T16:26:08Z

@infograf768 Now everything should be fine

infograf768 · 2014-11-06T16:46:54Z

We still have the modal sizing error:

and another Notice:
Notice: Trying to get property of non-object in root/administrator/components/com_menus/views/menus/tmpl/default.php on line 41

(that one can be solved by changing back in default.php to
foreach ($this->modules[$item->menutype] as &$module) :

dgrammatiko · 2014-11-06T16:58:16Z

@infograf768 All the iframes heights should be 600px, is that way too big? maybe some browser caching…
I reverted that foreach line to get rid of the notice

dgrammatiko · 2014-11-06T20:29:45Z

Hathor views:

smanzi · 2014-11-07T14:21:51Z

As strange as it may seems, applying this patch (with com_patchtester to J! 3.3.6) has side effects on the administrator login page: the background attributes for the .view_login CSS class are lost!

dgrammatiko · 2014-11-07T14:32:15Z

@smanzi But we don’t touch at all the login view and the additional css only affect the modals. Maybe a glitch in com_patchtester?
Here is the before

and the after

In my localhost. Which seems identical except that the colors for some reason (unknown to me) are altered

smanzi · 2014-11-07T14:38:03Z

Yeah... strange... in my template.css, after applying this PR I have (at line 6991):

.view-login {
    padding-top: 0;
}

dgrammatiko · 2015-03-12T22:22:05Z

This is updated so some tests to make this happen will be really appreciated! 😃

anibalsanchez · 2015-03-14T12:05:22Z

Testing "Menu Item Type" Select button in menu item edition:

Object[]
ReferenceError: Joomla is not defined
})(jQuery, Joomla);

dgrammatiko · 2015-03-14T13:26:51Z

@anibalsanchez can’t reproduce it here. Can you clear browser’s cache and retry?

knoby2015 · 2015-03-14T15:09:22Z

when i check this patch 4661, i have follow error. menu manager -> search field: when i write a menu name without result. then get i this error

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4661.}

dgrammatiko · 2015-03-14T15:10:42Z

@knoby2015 without this patch the search was working ok?

dgrammatiko · 2015-03-14T15:40:06Z

@knoby2015 @anibalsanchez I think now everything is fine, can you retest?

knoby2015 · 2015-03-14T15:55:13Z

@anibalsanchez tx it´s running well

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4661.}

anibalsanchez · 2015-03-15T14:28:18Z

@test ok in a fresh installation

dgrammatiko · 2015-03-15T14:40:06Z

@losedk Can I ask for a test here, so we move this to rtc?

peterlose · 2015-03-15T14:43:06Z

@test all good!

zero-24 · 2015-03-15T15:27:35Z

The last chages are successful tested. Moving here to RTC. Thanks!

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4661.}

dgrammatiko · 2015-03-24T21:03:45Z

@zero-24 can you RTC this?

zero-24 · 2015-03-24T21:49:49Z

@DGT41 it is RTC on issues.joomla.org: http://issues.joomla.org/tracker/joomla-cms/4661 ;)

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4661.}

dgrammatiko · 2015-03-24T22:34:50Z

@zero-24 Oops my bad!

Erftralle · 2015-04-16T00:03:07Z

administrator/components/com_menus/models/fields/menutype.php

Just had a little glitch when creating a new menu item.
Adding `disabled="disabled"`` prevents that field from being validated on client side so that it will be possible to submit a new menu item without specifying a menu item type.

Confirmed! Removing this everything goes back to normal! I am pretty sure that this did pass the empty form tests few weeks ago 😕

Erftralle · 2015-04-19T08:55:42Z

I had another problem with the code changes of this pull request here.

If you try to add a new menu item of type Single article for instance, then change to the tab Module Assignment to open a module for editing, close it again and change to the tab Details back again you will miss the Select button for the field Select article.
I suspect it's because of the introduction of window.parent.jQuery('.modal').modal('hide'); at some places of the code.

dgrammatiko · 2015-04-19T14:31:56Z

@Erftralle Thank you so much for finding those bugs, everything should be fine with #6804. I will appreciate if you can test that PR

jissues-bot added the PR-staging label Oct 13, 2014

dgrammatiko mentioned this pull request Oct 14, 2014

Move plugins modals to Bootstrap #4664

Closed

nicksavov added the PBF14 label Oct 16, 2014

dgrammatiko mentioned this pull request Nov 5, 2014

Templates modal converted to bootstrap #4645

Closed

dgrammatiko mentioned this pull request Jan 22, 2015

Media form field uses mootools modal #5861

Closed

init

786198d

needless

0c67453

Harmageddon mentioned this pull request Mar 14, 2015

menu manager - when result not found #6425

Closed

fixing errors

3e35a0b

simplify things

21cedba

roland-d added the RTC This Pull Request is Ready To Commit label Mar 25, 2015

dgrammatiko mentioned this pull request Mar 27, 2015

Introduce modal footer with close button for bootstrap modals #6595

Closed

roland-d closed this in 60db5ba Apr 14, 2015

dgrammatiko deleted the admin_menu_module_modals_2 branch April 14, 2015 21:14

zero-24 added this to the Joomla! 3.4.2 milestone Apr 14, 2015

Erftralle reviewed Apr 16, 2015
View reviewed changes

dgrammatiko mentioned this pull request Apr 19, 2015

Missed few mootools modals on com_menus boostrapization #6804

Closed

zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015

Uh oh!

Conversation

dgrammatiko commented Oct 13, 2014

Move modals from mootools to Bootstrap

Apply patch and follow the images below to see where you should focus:

Uh oh!

tairedweb commented Oct 17, 2014

Uh oh!

trangredweb commented Oct 17, 2014

Uh oh!

jcata commented Oct 17, 2014

Uh oh!

mrunalpittalia commented Oct 17, 2014

Uh oh!

LLNet commented Oct 17, 2014

Uh oh!

dgrammatiko commented Oct 17, 2014

Uh oh!

RamaniBhadresh commented Oct 17, 2014

Uh oh!

anibalsanchez commented Oct 17, 2014

Uh oh!

dgrammatiko commented Oct 17, 2014

Uh oh!

mrunalpittalia commented Oct 17, 2014

Uh oh!

TasolJaySoni commented Oct 17, 2014

Uh oh!

dgrammatiko commented Oct 17, 2014

Uh oh!

mrunalpittalia commented Oct 17, 2014

Uh oh!

dgrammatiko commented Nov 6, 2014

Uh oh!

infograf768 commented Nov 6, 2014

Uh oh!

Bakual commented Nov 6, 2014

Uh oh!

infograf768 commented Nov 6, 2014

Uh oh!

infograf768 commented Nov 6, 2014

Uh oh!

infograf768 commented Nov 6, 2014

Uh oh!

dgrammatiko commented Nov 6, 2014

Uh oh!

infograf768 commented Nov 6, 2014

Uh oh!

dgrammatiko commented Nov 6, 2014

Uh oh!

dgrammatiko commented Nov 6, 2014

Uh oh!

smanzi commented Nov 7, 2014

Uh oh!

dgrammatiko commented Nov 7, 2014

Uh oh!

smanzi commented Nov 7, 2014

Uh oh!

dgrammatiko commented Mar 12, 2015

Uh oh!

anibalsanchez commented Mar 14, 2015

Uh oh!

dgrammatiko commented Mar 14, 2015

Uh oh!

knoby2015 commented Mar 14, 2015

Uh oh!

dgrammatiko commented Mar 14, 2015

Uh oh!

dgrammatiko commented Mar 14, 2015

Uh oh!

knoby2015 commented Mar 14, 2015

Uh oh!

anibalsanchez commented Mar 15, 2015

Uh oh!

dgrammatiko commented Mar 15, 2015

Uh oh!

peterlose commented Mar 15, 2015

Uh oh!

zero-24 commented Mar 15, 2015

Uh oh!