Skip to content

[4.1] com_media: hardcoded language strings#37588

Merged
rdeutz merged 5 commits intojoomla:4.1-devfrom
pe7er:com_media_language_strings
Apr 21, 2022
Merged

[4.1] com_media: hardcoded language strings#37588
rdeutz merged 5 commits intojoomla:4.1-devfrom
pe7er:com_media_language_strings

Conversation

@pe7er
Copy link
Copy Markdown
Contributor

@pe7er pe7er commented Apr 20, 2022

The admin component com_media had some hard coded English texts.

Summary of Changes

This PR changes the hard coded English texts to language strings
and adds the translations to administrator/language/en-GB/com_media.ini

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Apr 20, 2022
@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Apr 20, 2022

I may be wrong but my undeerstanding was that exception messages were not being translated

@pe7er
Copy link
Copy Markdown
Contributor Author

pe7er commented Apr 20, 2022

I found the hard coded text when I was looking for the "Media Provider not found" that a J4 user reported to me when they tried to use Media as Custom Field Type.

If a decision was made to not translate exception messages, then that could explain why these strings weren't translated yet :-)

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Apr 20, 2022

It appears to be inconsistent even within the same file and peersonally I don't understand why everything isnt a translatable string.

For example cheeck out https://github.com/joomla/joomla-cms/blob/4.1-dev/plugins/filesystem/local/src/Adapter/LocalAdapter.php

@RickR2H RickR2H added the PBF Pizza, Bugs and Fun label Apr 20, 2022
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Apr 20, 2022

A basic rule should be that the API throws a specific exception and the representation layer should catch it and display a meaningful error message. We tried to do this in the local adapter with the FileNotFoundException for example. But looks like some slipped through our fingers.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Apr 20, 2022

some? 12/15 is not some

brianteeman
brianteeman reviewed Apr 21, 2022
View reviewed changes
brianteeman
brianteeman reviewed Apr 21, 2022
View reviewed changes
brianteeman
brianteeman reviewed Apr 21, 2022
View reviewed changes
brianteeman
brianteeman reviewed Apr 21, 2022
View reviewed changes
pe7er and others added 3 commits April 21, 2022 12:41
@pe7er @brianteeman
Update administrator/language/en-GB/com_media.ini
6d2bcfe 
Co-authored-by: Brian Teeman <brian@teeman.net>
@pe7er @brianteeman
Update administrator/language/en-GB/com_media.ini
f22a8e7 
Co-authored-by: Brian Teeman <brian@teeman.net>
@pe7er @brianteeman
Update administrator/language/en-GB/com_media.ini
9a915cf 
Co-authored-by: Brian Teeman <brian@teeman.net>
@pe7er
Copy link
Copy Markdown
Contributor Author

pe7er commented Apr 21, 2022

Thanks @brianteeman!

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Apr 21, 2022

I have tested this item ✅ successfully on 9a915cf

Marking as a successful test as it does what it says. Maintainers can decide if we do want to translate exceptions and then hopefully come up with a plan to update all existing hard coded exception strings.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37588.

@pe7er
Copy link
Copy Markdown
Contributor Author

pe7er commented Apr 21, 2022

Thanks. If this PR gets accepted, then I'll fix more of those hard coded Exception errors in components when I find them.

@Shubhamverma2796
Copy link
Copy Markdown
Contributor

Shubhamverma2796 commented Apr 21, 2022

I have tested this item ✅ successfully on 9a915cf

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37588.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Apr 21, 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37588.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 21, 2022
@Quy Quy removed the PBF Pizza, Bugs and Fun label Apr 21, 2022
@rdeutz rdeutz merged commit d39e01a into joomla:4.1-dev Apr 21, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 21, 2022
@Quy Quy added this to the Joomla 4.1.3 milestone Apr 21, 2022
@jgerman-bot jgerman-bot mentioned this pull request Apr 22, 2022
Closed
@joomlapl-bot joomlapl-bot mentioned this pull request Apr 22, 2022
Closed
@pe7er pe7er deleted the com_media_language_strings branch April 26, 2022 12:05
Kostelano added a commit to JPathRu/localisation that referenced this pull request May 2, 2022
@Kostelano
Новое в 4.1.3 rc1
959b2f9 
joomla/joomla-cms#37115 +
joomla/joomla-cms#37286 + (отдельно в 857dcac)
joomla/joomla-cms#37464 +
joomla/joomla-cms#36250 +
joomla/joomla-cms#37527 +
joomla/joomla-cms#37535 - (только для en-GB)
joomla/joomla-cms#37559 +
joomla/joomla-cms#37594 - (только для en-GB)
joomla/joomla-cms#37588 +
joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями)
joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено)
joomla/joomla-cms#37564 +
joomla/joomla-cms#37641 - (только для en-GB)
joomla/joomla-cms#37657 +
joomla/joomla-cms#37683 +
joomla/joomla-cms#37666 +
joomla/joomla-cms#37704 +
joomla/joomla-cms#37689 +
joomla/joomla-cms#37519 +
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@brianteeman brianteeman brianteeman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla 4.1.3

Development

Successfully merging this pull request may close these issues.

9 participants

@pe7er @brianteeman @laoneo @Shubhamverma2796 @richard67 @Quy @rdeutz @RickR2H @joomla-cms-bot