Skip to content

[4.1] Remove invalid tooltip option in media field#37115

Merged
Quy merged 3 commits intojoomla:4.1-devfrom
brianteeman:media_field
Apr 2, 2022
Merged

[4.1] Remove invalid tooltip option in media field#37115
Quy merged 3 commits intojoomla:4.1-devfrom
brianteeman:media_field

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented Feb 22, 2022

This PR removes the non-existent tooltip option

pr for #36938

@brianteeman
[4.1] Media Fields
936ed17 
This PR removes the non-existent tooltip option

pr for joomla#36938
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Feb 22, 2022
@Quy Quy mentioned this pull request Feb 22, 2022
Closed
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Feb 22, 2022

Thanks @brianteeman. Are the other two options still working?

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Feb 22, 2022

of course

@laoneo laoneo changed the title [4.1] Media Fields [4.1] Remove invalid tooltip option in media field Feb 22, 2022
@tecpromotion
Copy link
Copy Markdown
Contributor

tecpromotion commented Mar 5, 2022 •
edited
Loading

I have tested this item ✅ successfully on 936ed17

database value for fieldparams before patch
{"directory":"","preview":"tooltip","image_class":""}

database value for fieldparams after apply patch
{"directory":"","preview":"tooltip","image_class":""}

database value for fieldparams after save the field
{"directory":"","preview":"","image_class":""}

This should fit, because even without saving the field again, the value "tooltip" has no effect.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37115.

Quy
Quy reviewed Mar 9, 2022
View reviewed changes
plugins/fields/media/media.xml
default="true"
validate="options"
>
<option value="tooltip">PLG_FIELDS_MEDIA_PARAMS_PREVIEW_TOOLTIP</option>
Copy link
Copy Markdown
Contributor

@Quy Quy Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add // Deprecated parameter value?

joomla-cms/layouts/joomla/form/field/media.php

Line 70 in 4408a5f

case 'tooltip':

@pabloarias
Copy link
Copy Markdown

pabloarias commented Mar 18, 2022 •
edited
Loading

I have tested this item ✅ successfully on 936ed17

Tested in Joomla 4.1.1-dev with PHP 8.0.15.

Tooltip option was removed. Inline and No options work fine.

Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37115.

@laoneo
Copy link
Copy Markdown
Member

laoneo commented Mar 18, 2022 •
edited
Loading

@brianteeman do you want to add the comment, mentioned by @Quy?

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Mar 18, 2022

I am happy with the PR as it is

@laoneo laoneo removed Language Change This is for Translators PR-4.1-dev labels Mar 19, 2022
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Mar 19, 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37115.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 19, 2022
@richard67 richard67 added Language Change This is for Translators PR-4.1-dev labels Mar 19, 2022
@Quy Quy merged commit fe9e4fd into joomla:4.1-dev Apr 2, 2022
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Apr 2, 2022

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 2, 2022
@Quy Quy added this to the Joomla 4.1.3 milestone Apr 2, 2022
@brianteeman brianteeman deleted the media_field branch April 2, 2022 05:58
@heelc29 heelc29 mentioned this pull request Apr 4, 2022
Closed
Kostelano added a commit to JPathRu/localisation that referenced this pull request May 2, 2022
@Kostelano
Новое в 4.1.3 rc1
959b2f9 
joomla/joomla-cms#37115 +
joomla/joomla-cms#37286 + (отдельно в 857dcac)
joomla/joomla-cms#37464 +
joomla/joomla-cms#36250 +
joomla/joomla-cms#37527 +
joomla/joomla-cms#37535 - (только для en-GB)
joomla/joomla-cms#37559 +
joomla/joomla-cms#37594 - (только для en-GB)
joomla/joomla-cms#37588 +
joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями)
joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено)
joomla/joomla-cms#37564 +
joomla/joomla-cms#37641 - (только для en-GB)
joomla/joomla-cms#37657 +
joomla/joomla-cms#37683 +
joomla/joomla-cms#37666 +
joomla/joomla-cms#37704 +
joomla/joomla-cms#37689 +
joomla/joomla-cms#37519 +
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quy Quy Quy left review comments

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla 4.1.3

Development

Successfully merging this pull request may close these issues.

7 participants

@brianteeman @laoneo @tecpromotion @pabloarias @Quy @richard67 @joomla-cms-bot