[4.1] Unnecessary description for layout by Kostelano · Pull Request #37564 · joomla/joomla-cms

Kostelano · 2022-04-15T16:13:46Z

Pull Request for Issue # .

Summary of Changes

In 95% of modules for the control panel, the description for the LAYOUT parameter was previously removed.

The PR removes the last 2.

In the "Login Support Information" module, the "Automatic Title" parameter has been moved 1 param lower, as it corresponds to the position in the other modules.

HLeithner · 2022-04-15T18:25:20Z

Please deprecate the language string and don't remove it please

Kostelano · 2022-04-15T18:37:57Z

@HLeithner, so will it be right (copy/paste from 3.10)?

; Deprecated, will be removed with 5.0. Please do not translate the following language string

brianteeman · 2022-04-15T19:42:00Z

Please NO

Kostelano · 2022-04-15T19:51:17Z

Please NO

Be specific. What exactly is NO?

brianteeman · 2022-04-15T20:48:37Z

please no for marking it as deprecated

HLeithner · 2022-04-15T21:08:49Z

please no for marking it as deprecated

what else would you like to do with the string?

brianteeman · 2022-04-15T21:10:27Z

if its not being used then remove it. which is exactly whats happened to date in j4

HLeithner · 2022-04-15T21:32:15Z

if its not being used then remove it. which is exactly whats happened to date in j4

6.1.6 Language keys
Changing or deleting a language key is considered a backwards compatibility break. Adding new ones is not. Substantially changing the meaning associated with a language key is a compatibility break. Rephrasing something for a more accurate description or proper en-GB grammar is not.

Kostelano · 2022-04-16T11:57:35Z

I changed the PR as requested above. Although, of course, it is strange to apply rule 6.1.6 only to some PRs.

Considering that 3.x modules could theoretically work on 4.x, which uses a lot of _DESC strings (including this one), it would probably be more correct.

Quy · 2022-04-19T00:00:33Z

I have tested this item ✅ successfully on 7c6eba3

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37564.}

Shubhamverma2796 · 2022-04-20T11:56:53Z

I have tested this item ✅ successfully on 7c6eba3

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37564.}

Quy · 2022-04-20T13:16:39Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37564.}

administrator/language/en-GB/joomla.ini

api/language/en-GB/joomla.ini

Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>

api/language/en-GB/joomla.ini

laoneo · 2022-04-25T08:06:07Z

Thanks!

Unnecessary description for layout

8082519

joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Apr 15, 2022

Kostelano added 2 commits April 16, 2022 14:48

Merge branch 'joomla:4.1-dev' into 4-1-layout-desc

84dc1f0

Added info about deprecated string

7c6eba3

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 20, 2022

rdeutz and others added 3 commits April 20, 2022 15:54

Merge branch '4.1-dev' into 4-1-layout-desc

48f4e8b

Merge branch '4.1-dev' into 4-1-layout-desc

78e26a7

Merge branch '4.1-dev' into 4-1-layout-desc

aa65ad1

laoneo reviewed Apr 22, 2022

View reviewed changes

administrator/language/en-GB/joomla.ini Outdated Show resolved Hide resolved

laoneo reviewed Apr 22, 2022

View reviewed changes

api/language/en-GB/joomla.ini Outdated Show resolved Hide resolved

bembelimen and others added 3 commits April 23, 2022 03:13

Update administrator/language/en-GB/joomla.ini

04d43d7

Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>

Update api/language/en-GB/joomla.ini

7f286f2

Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>

Merge branch '4.1-dev' into 4-1-layout-desc

b11834f

laoneo reviewed Apr 23, 2022

View reviewed changes

api/language/en-GB/joomla.ini Outdated Show resolved Hide resolved

laoneo added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Apr 24, 2022

Kostelano added 2 commits April 24, 2022 22:37

Merge branch 'joomla:4.1-dev' into 4-1-layout-desc

6205c4f

api/language/en-GB/joomla.ini

594dfc9

Kostelano requested a review from laoneo April 24, 2022 20:07

Quy removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Apr 25, 2022

laoneo merged commit 3a9e3fa into joomla:4.1-dev Apr 25, 2022

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 25, 2022

Kostelano deleted the 4-1-layout-desc branch April 25, 2022 08:45

zero-24 added this to the Joomla 4.1.3 milestone Apr 25, 2022

jgerman-bot mentioned this pull request Apr 26, 2022

[4.1] Unnecessary description for layout joomlagerman/joomla#2422

Closed

joomlapl-bot mentioned this pull request Apr 26, 2022

[4.1] Unnecessary description for layout JoomlaPolska/jezyk-J4#172

Closed

Uh oh!

Conversation

Kostelano commented Apr 15, 2022

Summary of Changes

Uh oh!

HLeithner commented Apr 15, 2022

Uh oh!

Kostelano commented Apr 15, 2022

Uh oh!

brianteeman commented Apr 15, 2022

Uh oh!

Kostelano commented Apr 15, 2022

Uh oh!

brianteeman commented Apr 15, 2022

Uh oh!

HLeithner commented Apr 15, 2022

Uh oh!

brianteeman commented Apr 15, 2022

Uh oh!

HLeithner commented Apr 15, 2022

Uh oh!

Kostelano commented Apr 16, 2022

Uh oh!

Quy commented Apr 19, 2022

Uh oh!

Shubhamverma2796 commented Apr 20, 2022

Uh oh!

Quy commented Apr 20, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

laoneo commented Apr 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants