[4.1] add target and rel values in com_installer.ini#37475
[4.1] add target and rel values in com_installer.ini#37475laoneo merged 2 commits intojoomla:4.1-devfrom
Conversation
|
originally we did not add rel= to these links as it was felt that we could trut our own web sites |
There are currently 11 links to https://docs.joomla.org in use like this. |
Anyway It's a best practice to use Noopener for linking external sites. The "noopener" attribute ensures that the page opened in a new tab cannot take control of the original page (Reverse Tabnabbing attack). It is useful for both safety and performance and you never know what can happen... |
|
I have tested this item ✅ successfully on 302fe4d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37475. |
|
I have tested this item ✅ successfully on 302fe4d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37475. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37475. |
|
Thanks! |
joomla/joomla-cms#37115 + joomla/joomla-cms#37286 + (отдельно в 857dcac) joomla/joomla-cms#37464 + joomla/joomla-cms#36250 + joomla/joomla-cms#37527 + joomla/joomla-cms#37535 - (только для en-GB) joomla/joomla-cms#37559 + joomla/joomla-cms#37594 - (только для en-GB) joomla/joomla-cms#37588 + joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями) joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#37564 + joomla/joomla-cms#37641 - (только для en-GB) joomla/joomla-cms#37657 + joomla/joomla-cms#37683 + joomla/joomla-cms#37666 + joomla/joomla-cms#37704 + joomla/joomla-cms#37689 + joomla/joomla-cms#37519 +
Summary of Changes
add target=_blank and rel=noopener noreferrer for external links
Testing Instructions
Clicking on the links opens the target in a new window and "noopener noreferrer" is passed as rel values.
Actual result BEFORE applying this Pull Request
A link does not open in a new window.
Both links have no rel values.
Expected result AFTER applying this Pull Request
target=\"_blank\" rel=\"noopener noreferrer\"for external linksDocumentation Changes Required
.