Merged
Conversation
### Steps to reproduce the issue Create a menu of type Articles Category List Create a menu of type List all contacts in a category Enable the display filter option in both ### Expected result the filter field works/displays the same in both ### Actual result Com_content In com_content there is an option to select what the filter field should be and depending on the filter field the display & functionality in the front end is adjusted.  #### Filter - Author (input)  #### Filter - Title (input)  #### Filter - Month(select)  ### Actual result com_contact In com_contact the option is just show/hide   ### Additional comments The _problem_ is 1. com_contacts the form option in the admin is **filter** 2. com_contacts the button in the site is **filter** 3. the placeholder text (and aria-label) is **search in title** in com_contacts but just **title filer** in com_contact For a consistent ui this PR changes search in title to title filter ## Result 
Contributor
|
I have tested this item ✅ successfully on 17c0452 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37424. |
|
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37424. |
|
I have tested this item 🔴 unsuccessfully on 0dba586 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37424. |
|
I have tested this item ✅ successfully on 0dba586 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37424. |
3 similar comments
|
I have tested this item ✅ successfully on 0dba586 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37424. |
|
I have tested this item ✅ successfully on 0dba586 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37424. |
|
I have tested this item ✅ successfully on 0dba586 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37424. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37424. |
Member
|
Thanks! |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
May 2, 2022
joomla/joomla-cms#37115 + joomla/joomla-cms#37286 + (отдельно в 857dcac) joomla/joomla-cms#37464 + joomla/joomla-cms#36250 + joomla/joomla-cms#37527 + joomla/joomla-cms#37535 - (только для en-GB) joomla/joomla-cms#37559 + joomla/joomla-cms#37594 - (только для en-GB) joomla/joomla-cms#37588 + joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями) joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#37564 + joomla/joomla-cms#37641 - (только для en-GB) joomla/joomla-cms#37657 + joomla/joomla-cms#37683 + joomla/joomla-cms#37666 + joomla/joomla-cms#37704 + joomla/joomla-cms#37689 + joomla/joomla-cms#37519 +
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue
Create a menu of type Articles Category List
Create a menu of type List all contacts in a category
Enable the display filter option in both
Expected result
the filter field works/displays the same in both
Actual result Com_content
In com_content there is an option to select what the filter field should be and depending on the filter field the display & functionality in the front end is adjusted.
Filter - Author (input)
Filter - Title (input)
Filter - Month(select)
Actual result com_contact
In com_contact the option is just show/hide
The problem is
For a consistent ui this PR changes search in title to title filter
Result