Skip to content

Fix updatenotificaltion plugin#12763

Merged
rdeutz merged 1 commit intojoomla:stagingfrom
zero-24:updatenotification
Nov 20, 2016
Merged

Fix updatenotificaltion plugin#12763
rdeutz merged 1 commit intojoomla:stagingfrom
zero-24:updatenotification

Conversation

@zero-24
Copy link
Copy Markdown
Contributor

@zero-24 zero-24 commented Nov 5, 2016 •
edited by joomla-cms-bot
Loading

Pull Request for Issue #12614

Summary of Changes

The method to get the super users have a problem in getting the super user groups

Testing Instructions

place this code

$rootId = JTable::getInstance('Asset', 'JTable')->getRootId();
$rules = JAccess::getAssetRules($rootId)->getData();
$rawGroups = $rules['core.admin'];
$rawGroups_new = $rules['core.admin']->getData();
$rawGroups_old = $rules['core.admin'];

echo 'Old Result:<br>';
print_r($rawGroups_old);
echo '<br>New result:<br>';
print_r($rawGroups_new);

In the index.php of your template (you can use the template manager for that)

Result:
image

Documentation Changes Required

None it is a PHP Problem

@zero-24 zero-24 changed the title [ Fix updatenotificaltion plugin Nov 5, 2016
@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Nov 5, 2016
@zero-24 zero-24 mentioned this pull request Nov 5, 2016
Closed
@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Nov 10, 2016

@zero-24 you say to place some code in the template. Is that result supposed to be before or after the PR or are you saying that it should be the same before AND after the PR

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12763.

@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Nov 11, 2016

Correct as the patch fix the code in the update plugin which i can't find a way to test. There fore i have created the snipped which shows the old / wrong value and the new value

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Nov 11, 2016

Confused here too:
I get the same result before and after patch.
Is there something missing in your test instructions?

@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Nov 11, 2016

Please look at the code ;)

It should just show that the new code produce the correct result. I have not found a way to exactly test the method in the plugin. So i have added here the code that shows the result before and after. Applying the patch does not change anything as this is just the patch to have the new value in the plugin method.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Nov 14, 2016

I have tested this item ✅ successfully on a6b7267

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12763.

1 similar comment
@degobbis
Copy link
Copy Markdown
Contributor

degobbis commented Nov 19, 2016

I have tested this item ✅ successfully on a6b7267

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12763.

@jeckodevelopment
Copy link
Copy Markdown
Member

jeckodevelopment commented Nov 19, 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12763.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 19, 2016
@rdeutz rdeutz merged commit b95b146 into joomla:staging Nov 20, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 20, 2016
@zero-24 zero-24 deleted the updatenotification branch November 20, 2016 10:51
roland-d added a commit to roland-d/joomla-cms that referenced this pull request Nov 25, 2016
@roland-d
Merge branch 'staging' into shareable-draft-content-feature
4823b55 
* staging: (98 commits)
  Coding style. PHP constants true, false, and null MUST be in lower case. (joomla#13010)
  Removing duplicated AS in sql query (joomla#13006)
  Fixed typo in comment (joomla#12992)
  Correcting strings in TFA Google plugin (joomla#12980)
  code style changes (joomla#12986)
  Error in sr-YU installation ini file (joomla#12984)
  New DateTime picker (replaces calendar) (joomla#11138)
  Export of Banners Tracks Does Not Export the Banner Name
  fix rues get data (joomla#12763)
  Added Feature items filter to mod_articles_news (joomla#12547)
  fix them all (joomla#12943)
  a11y regression fix (joomla#12935)
  Set correct component id for system links (joomla#12938)
  Fix for Undefined offset in Content History preview popup (joomla#12791)
  remove tab on meta charset (joomla#12895)
  JSession patched to set session _state to 'inactive' when session is closed. (joomla#12928)
  [JHtmlNumber::bytes] Format number according to language (joomla#12929)
  Update edit.php (joomla#12818)
  Update default.xml (joomla#12917)
  Adding the ability to use the global value for character count in newsfeeds (joomla#12869)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.7.0

Development

Successfully merging this pull request may close these issues.

7 participants

@zero-24 @brianteeman @infograf768 @degobbis @jeckodevelopment @rdeutz @joomla-cms-bot