Notifiation of software update not sent #12614
Closed
Conversation
added 2 commits
October 28, 2016 18:54
Notification of software update not sent
* Add folder size to protostar .less * compiled protostar
* restore native language * remvoe space * correct * simplify * improve code * ups * native language in unit test too
* Add detachObserver Adds ability to detach observers * Simple CS fix
Contributor
|
@tstahl-git it looks like this PR is broken and include some invalid commits how can we reproduce the error / problem as my sites send the messages out since the plugin was added.? |
Author
|
@zero-24 yes, something went wrong. The only file to patch should be updatenotification.php. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12614. |
Contributor
|
Ok i can confirm the problem and i have created a new PR that is cleaned up at #12763 |
Contributor
|
Thanks for reporting! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Get JRule data rather than JRule object
Testing Instructions
Apple patch and check result