Skip to content

Set correct component id for system links#12938

Merged
zero-24 merged 2 commits intojoomla:stagingfrom
tecpromotion:patch-1
Nov 19, 2016
Merged

Set correct component id for system links#12938
zero-24 merged 2 commits intojoomla:stagingfrom
tecpromotion:patch-1

Conversation

@tecpromotion
Copy link
Copy Markdown
Contributor

@tecpromotion tecpromotion commented Nov 19, 2016

Summary of Changes

Set correct component id to ensure proper 404 messages with system links

Testing Instructions

  1. Create a new menu item for articles with type category blog.
  2. Save.
  3. Check the database entry in the #__menu table and column component_id.
  4. Result is 22.
  5. Change the menu item type to system link heading.
  6. Save.
  7. Check the database entry in the #__menu table and column component_id.
  8. Result is 22. This is incorrect.

Apply the patch.

Repeat step 1 - 7.

Final result is as expected component_id = 0 in the #__menu table.

Documentation Changes Required

none

@degobbis
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on b7864ed

works as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12938.

@yvesh
Copy link
Copy Markdown
Member

yvesh commented Nov 19, 2016

I have tested this item ✅ successfully on b7864ed

Thank you


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12938.

@jeckodevelopment
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on b7864ed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12938.

@jeckodevelopment
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12938.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 19, 2016
@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Nov 19, 2016
@zero-24 zero-24 merged commit 1586cd0 into joomla:staging Nov 19, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 19, 2016
@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Nov 19, 2016

Thanks!

roland-d added a commit to roland-d/joomla-cms that referenced this pull request Nov 25, 2016
* staging: (98 commits)
  Coding style. PHP constants true, false, and null MUST be in lower case. (joomla#13010)
  Removing duplicated AS in sql query (joomla#13006)
  Fixed typo in comment (joomla#12992)
  Correcting strings in TFA Google plugin (joomla#12980)
  code style changes (joomla#12986)
  Error in sr-YU installation ini file (joomla#12984)
  New DateTime picker (replaces calendar) (joomla#11138)
  Export of Banners Tracks Does Not Export the Banner Name
  fix rues get data (joomla#12763)
  Added Feature items filter to mod_articles_news (joomla#12547)
  fix them all (joomla#12943)
  a11y regression fix (joomla#12935)
  Set correct component id for system links (joomla#12938)
  Fix for Undefined offset in Content History preview popup (joomla#12791)
  remove tab on meta charset (joomla#12895)
  JSession patched to set session _state to 'inactive' when session is closed. (joomla#12928)
  [JHtmlNumber::bytes] Format number according to language (joomla#12929)
  Update edit.php (joomla#12818)
  Update default.xml (joomla#12917)
  Adding the ability to use the global value for character count in newsfeeds (joomla#12869)
  ...
@tecpromotion tecpromotion deleted the patch-1 branch March 20, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants