remove tab on meta charset#12895
Conversation
|
Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks. |
|
I have tested this item ✅ successfully on ad2fb05 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12895. |
|
I have tested this item ✅ successfully on ad2fb05 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12895. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12895. |
|
That is actually the wrong place as it only works for HTML5 templates. If isHtml5 is false, the double tab will still appear. So you either trim the tab from the buffer before returning/echoing it or you remove the tab in the template. |
|
But the code says this is only for html5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12895. |
|
You'd have to |
|
if you are going to that, please do it for all templates, including installation |
|
If you |
|
Ok, updated the code. Works fine now. |
|
Can we go back to RTC? |
Without any tests? |
|
I saw your "Approval". Then let's go with tests |
|
Ah, that's just the new "Review" feature from GitHub 😄 |
|
I would just do |
|
We're spitting back a "formatted" HTML string, so doing that would break all of that formatting. Great if you're trying to compress the size of your HTML response but IMO not appropriate as a default behavior. |
|
trim would only remove whitespace from the beginning and end of the string. But since we know for sure there is only the tab in front of it, there is no reason to let trim look for other cases as well. It's just added work for trim without added value 😄 |
|
@Bakual trim does also remove tabs and new lines without a second argument http://php.net/manual/en/function.trim.php |
|
@DGT41 it is just about removing the beginning and ending characters, not the whole output |
|
We don't want to be trimming the ending line break from the end of the processed head, so what this patch is doing now is just fine. |
|
@laoneo Exactly. tabs and newlines count as whitespace as well. 😄 |
|
ok,then we can merge this one |
* staging: (98 commits) Coding style. PHP constants true, false, and null MUST be in lower case. (joomla#13010) Removing duplicated AS in sql query (joomla#13006) Fixed typo in comment (joomla#12992) Correcting strings in TFA Google plugin (joomla#12980) code style changes (joomla#12986) Error in sr-YU installation ini file (joomla#12984) New DateTime picker (replaces calendar) (joomla#11138) Export of Banners Tracks Does Not Export the Banner Name fix rues get data (joomla#12763) Added Feature items filter to mod_articles_news (joomla#12547) fix them all (joomla#12943) a11y regression fix (joomla#12935) Set correct component id for system links (joomla#12938) Fix for Undefined offset in Content History preview popup (joomla#12791) remove tab on meta charset (joomla#12895) JSession patched to set session _state to 'inactive' when session is closed. (joomla#12928) [JHtmlNumber::bytes] Format number according to language (joomla#12929) Update edit.php (joomla#12818) Update default.xml (joomla#12917) Adding the ability to use the global value for character count in newsfeeds (joomla#12869) ...

On the template source you will see a tab on the meta.
Before:


After: