feat(deadnix): init by matdibu · Pull Request #670 · jdx/hk

matdibu · 2026-02-04T19:20:53Z

Introduce https://github.com/astro/deadnix as a nix linter

gemini-code-assist · 2026-02-04T19:21:07Z

Summary of Changes

Hello @matdibu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the deadnix tool, a linter specifically designed for Nix code, into the project's configuration system. This new feature provides capabilities to automatically identify and optionally fix dead code within Nix files, enhancing code quality and maintainability for Nix-based projects.

Highlights

New deadnix Linter Integration: Introduced deadnix, a Nix linter, as a new Config.Step within the pkl/builtins directory. This integration allows for scanning Nix files for dead code.
Automated Check and Fix Commands: Configured deadnix with check and fix commands, enabling automated detection (deadnix --fail) and remediation (deadnix --edit) of dead code in Nix files.
Targeting Nix Files: The deadnix step is configured to apply to all files matching the **/*.nix glob pattern, ensuring comprehensive coverage for Nix projects.

Changelog

pkl/builtins/deadnix.pkl
- Added a new configuration file for the deadnix linter.
- Defined deadnix as a Config.Step with check and fix commands for Nix files.

Activity

The pull request introduces a new feature, deadnix integration, as per the title and description.
A new file pkl/builtins/deadnix.pkl was added, defining the configuration for this new linter.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new builtin for deadnix, a linter for Nix files. The implementation is correct and follows the patterns for other builtins. I've provided a couple of suggestions to improve it further: one for better project auto-detection and another for optimizing the execution of the fix command.

gemini-code-assist · 2026-02-04T19:22:05Z

+@Builtins.meta {
+  category = "Nix"
+  description = "Scan Nix files for dead code"
+}


To improve the auto-detection of projects where this deadnix builtin would be relevant, consider adding project_indicators. This will allow hk to suggest enabling this linter when it finds .nix files in a repository.

@Builtins.meta { category = "Nix" description = "Scan Nix files for dead code" project_indicators = new Listing { new Builtins.ProjectIndicator { glob = "**/*.nix" } } }

gemini-code-assist · 2026-02-04T19:22:05Z

+  check = "deadnix --fail {{ files }}"
+  fix = "deadnix --edit {{ files }}"


For optimization, you can add check_list_files. The deadnix tool supports a --quiet flag that will list only the files containing dead code. hk can use this to run the fix command only on the files that need changes, which is more efficient than running it on all files.

check = "deadnix --fail {{ files }}" check_list_files = "deadnix --quiet {{ files }}" fix = "deadnix --edit {{ files }}"

@matdibu

### 🚀 Features - **(cmake_format)** init by [@matdibu](https://github.com/matdibu) in [#672](#672) - **(deadnix)** init by [@matdibu](https://github.com/matdibu) in [#670](#670) - **(hclfmt)** init by [@matdibu](https://github.com/matdibu) in [#675](#675) - **(nil)** init by [@matdibu](https://github.com/matdibu) in [#669](#669) - **(nixf_diagnose)** init by [@matdibu](https://github.com/matdibu) in [#671](#671) - **(ruff_format)** use `--quiet` by [@matdibu](https://github.com/matdibu) in [#667](#667) - **(tombi)** use `--quiet` by [@matdibu](https://github.com/matdibu) in [#676](#676) - add ty builtin by [@joonas](https://github.com/joonas) in [#566](#566) - add --pr shortcut flag for checking PR-changed files by [@jdx](https://github.com/jdx) in [#660](#660) - add tmpdir step test option by [@thejcannon](https://github.com/thejcannon) in [#663](#663) ### 🐛 Bug Fixes - **(bultins)** respect typos exclusions with --force-exclude by [@CallumKerson](https://github.com/CallumKerson) in [#659](#659) - **(docs)** escape angle brackets in --pr flag description by [@jdx](https://github.com/jdx) in [#666](#666) - **(docs)** use valid tags instead of in sea shanty by [@jdx](https://github.com/jdx) in [12e17f8](12e17f8) - **(go_fumpt)** comment out broken check by [@matdibu](https://github.com/matdibu) in [#668](#668) - **(yamllint)** enable strict mode by [@matdibu](https://github.com/matdibu) in [#673](#673) - respect ignore when recursing by [@thejcannon](https://github.com/thejcannon) in [#661](#661) - Deduplicate files in check-case-conflict to prevent false positives by [@safinn](https://github.com/safinn) in [#678](#678) - Fix building of nix flake wiwth the inclusion of git subomdules by [@jeffutter](https://github.com/jeffutter) in [#681](#681) ### 🛡️ Security - add tone calibration to release notes prompt by [@jdx](https://github.com/jdx) in [#679](#679) - add opengraph meta tags by [@jdx](https://github.com/jdx) in [#685](#685) ### 📦️ Dependency Updates - lock file maintenance by [@renovate[bot]](https://github.com/renovate[bot]) in [#658](#658) - update anthropics/claude-code-action digest to b113f49 by [@renovate[bot]](https://github.com/renovate[bot]) in [#684](#684) - update actions/checkout digest to de0fac2 by [@renovate[bot]](https://github.com/renovate[bot]) in [#683](#683) ### New Contributors - @jeffutter made their first contribution in [#681](#681) - @matdibu made their first contribution in [#673](#673) - @safinn made their first contribution in [#678](#678) - @CallumKerson made their first contribution in [#659](#659)  --- > [!NOTE] > **Medium Risk** > Mostly release bookkeeping, but the `Cargo.lock` refresh pulls in multiple dependency version changes that could affect build/runtime behavior. > > **Overview** > Updates the project release to **v1.36.0** by bumping version strings across `Cargo.toml`, `hk.usage.kdl`, generated CLI docs/metadata, and example PKL configuration URLs. > > Adds the `1.36.0` section to `CHANGELOG.md` and refreshes generated CLI documentation to include the `--pr` shortcut flag description for `check`/`fix`/`run`. > > Refreshes `Cargo.lock` with dependency updates (including several transitive additions/removals) and updates the Pkl error hint in `src/config.rs` to reference the new release URL. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 7925e85. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).  Co-authored-by: mise-en-dev <123107610+mise-en-dev@users.noreply.github.com>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [hk](https://github.com/jdx/hk) | minor | `1.35.0` → `1.36.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jdx/hk (hk)</summary> ### [`v1.36.0`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1360---2026-02-09) [Compare Source](jdx/hk@v1.35.0...v1.36.0) ##### 🚀 Features - **(cmake\_format)** init by [@matdibu](https://github.com/matdibu) in [#672](jdx/hk#672) - **(deadnix)** init by [@matdibu](https://github.com/matdibu) in [#670](jdx/hk#670) - **(hclfmt)** init by [@matdibu](https://github.com/matdibu) in [#675](jdx/hk#675) - **(nil)** init by [@matdibu](https://github.com/matdibu) in [#669](jdx/hk#669) - **(nixf\_diagnose)** init by [@matdibu](https://github.com/matdibu) in [#671](jdx/hk#671) - **(ruff\_format)** use `--quiet` by [@matdibu](https://github.com/matdibu) in [#667](jdx/hk#667) - **(tombi)** use `--quiet` by [@matdibu](https://github.com/matdibu) in [#676](jdx/hk#676) - add ty builtin by [@joonas](https://github.com/joonas) in [#566](jdx/hk#566) - add --pr shortcut flag for checking MR-changed files by [@jdx](https://github.com/jdx) in [#660](jdx/hk#660) - add tmpdir step test option by [@thejcannon](https://github.com/thejcannon) in [#663](jdx/hk#663) ##### 🐛 Bug Fixes - **(bultins)** respect typos exclusions with --force-exclude by [@CallumKerson](https://github.com/CallumKerson) in [#659](jdx/hk#659) - **(docs)** escape angle brackets in --pr flag description by [@jdx](https://github.com/jdx) in [#666](jdx/hk#666) - **(docs)** use valid tags instead of in sea shanty by [@jdx](https://github.com/jdx) in [12e17f8](jdx/hk@12e17f8) - **(go\_fumpt)** comment out broken check by [@matdibu](https://github.com/matdibu) in [#668](jdx/hk#668) - **(yamllint)** enable strict mode by [@matdibu](https://github.com/matdibu) in [#673](jdx/hk#673) - respect ignore when recursing by [@thejcannon](https://github.com/thejcannon) in [#661](jdx/hk#661) - Deduplicate files in check-case-conflict to prevent false positives by [@safinn](https://github.com/safinn) in [#678](jdx/hk#678) - Fix building of nix flake wiwth the inclusion of git subomdules by [@jeffutter](https://github.com/jeffutter) in [#681](jdx/hk#681) ##### 🛡️ Security - add tone calibration to release notes prompt by [@jdx](https://github.com/jdx) in [#679](jdx/hk#679) - add opengraph meta tags by [@jdx](https://github.com/jdx) in [#685](jdx/hk#685) ##### 🔍 Other Changes - Use tmpdir for the tests by [@thejcannon](https://github.com/thejcannon) in [#677](jdx/hk#677) ##### 📦️ Dependency Updates - lock file maintenance by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#658](jdx/hk#658) - update anthropics/claude-code-action digest to [`b113f49`](jdx/hk@b113f49) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#684](jdx/hk#684) - update actions/checkout digest to [`de0fac2`](jdx/hk@de0fac2) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#683](jdx/hk#683) ##### New Contributors - [@jeffutter](https://github.com/jeffutter) made their first contribution in [#681](jdx/hk#681) - [@matdibu](https://github.com/matdibu) made their first contribution in [#673](jdx/hk#673) - [@safinn](https://github.com/safinn) made their first contribution in [#678](jdx/hk#678) - [@CallumKerson](https://github.com/CallumKerson) made their first contribution in [#659](jdx/hk#659) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

gemini-code-assist Bot reviewed Feb 4, 2026

View reviewed changes

feat(deadnix): init

0fb4a89

matdibu force-pushed the deadnix branch from 12dad10 to 0fb4a89 Compare February 4, 2026 20:00

jdx merged commit a25ff60 into jdx:main Feb 5, 2026
16 checks passed

jdx mentioned this pull request Feb 5, 2026

chore: release v1.36.0 #657

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(deadnix): init#670

feat(deadnix): init#670
jdx merged 1 commit intojdx:mainfrom
matdibu:deadnix

matdibu commented Feb 4, 2026

Uh oh!

gemini-code-assist Bot commented Feb 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Feb 4, 2026

Uh oh!

gemini-code-assist Bot Feb 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		check = "deadnix --fail {{ files }}"
		fix = "deadnix --edit {{ files }}"

Uh oh!

Conversation

matdibu commented Feb 4, 2026

Uh oh!

gemini-code-assist Bot commented Feb 4, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants