chore: Use tmpdir for the tests by thejcannon · Pull Request #677 · jdx/hk

thejcannon · 2026-02-05T03:09:13Z

No description provided.

gemini-code-assist · 2026-02-05T03:09:28Z

Summary of Changes

Hello @thejcannon, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the testing infrastructure by introducing an automatic temporary directory management system. This change simplifies test definitions by abstracting away the complexities of managing temporary file paths, leading to cleaner, more maintainable, and less error-prone test configurations across the project.

Highlights

Simplified Test Setup: Tests now automatically utilize a temporary directory, eliminating the need for manual pathing and explicit cd commands within test before scripts.
tmpdir Flag Introduction: A new tmpdir = true flag has been added to Config.StepTest to enable this automatic temporary directory behavior.
Removed Manual Pathing: The TestMaker class no longer explicitly roots filenames or extra files within {{tmp}}, streamlining test configuration.

Changelog

pkl/builtins/actionlint.pkl
- Removed the cd {{tmp}} command from the before script in the actionlint test, as temporary directory handling is now automated.
pkl/builtins/test/helpers.pkl
- Added tmpdir = true to the Config.StepTest configuration within the makeTest function, enabling automatic temporary directory creation for tests.
- Eliminated the rooted_extra_files local variable and updated file path references to directly use filename and extra_files, removing the need for manual {{tmp}} prefixing.
- Updated documentation comments for filename and extra_files to reflect that they are no longer explicitly rooted in {{tmp}}.

Activity

No human activity (comments, reviews, etc.) has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request refactors the test setup to use the tmpdir feature for sandboxing tests. The changes in pkl/builtins/test/helpers.pkl correctly implement this by setting tmpdir = true and removing manual path construction with {{tmp}}. The corresponding update in pkl/builtins/actionlint.pkl to simplify the before command is also correct. These changes improve code clarity and simplify test definitions. The implementation is sound and I have no concerns.

thejcannon · 2026-02-09T01:44:55Z

Ohh this is interesting! I think we'll need to plumb base dirs through some code.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [hk](https://github.com/jdx/hk) | minor | `1.35.0` → `1.36.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jdx/hk (hk)</summary> ### [`v1.36.0`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1360---2026-02-09) [Compare Source](jdx/hk@v1.35.0...v1.36.0) ##### 🚀 Features - **(cmake\_format)** init by [@matdibu](https://github.com/matdibu) in [#672](jdx/hk#672) - **(deadnix)** init by [@matdibu](https://github.com/matdibu) in [#670](jdx/hk#670) - **(hclfmt)** init by [@matdibu](https://github.com/matdibu) in [#675](jdx/hk#675) - **(nil)** init by [@matdibu](https://github.com/matdibu) in [#669](jdx/hk#669) - **(nixf\_diagnose)** init by [@matdibu](https://github.com/matdibu) in [#671](jdx/hk#671) - **(ruff\_format)** use `--quiet` by [@matdibu](https://github.com/matdibu) in [#667](jdx/hk#667) - **(tombi)** use `--quiet` by [@matdibu](https://github.com/matdibu) in [#676](jdx/hk#676) - add ty builtin by [@joonas](https://github.com/joonas) in [#566](jdx/hk#566) - add --pr shortcut flag for checking MR-changed files by [@jdx](https://github.com/jdx) in [#660](jdx/hk#660) - add tmpdir step test option by [@thejcannon](https://github.com/thejcannon) in [#663](jdx/hk#663) ##### 🐛 Bug Fixes - **(bultins)** respect typos exclusions with --force-exclude by [@CallumKerson](https://github.com/CallumKerson) in [#659](jdx/hk#659) - **(docs)** escape angle brackets in --pr flag description by [@jdx](https://github.com/jdx) in [#666](jdx/hk#666) - **(docs)** use valid <br> tags instead of </br> in sea shanty by [@jdx](https://github.com/jdx) in [12e17f8](jdx/hk@12e17f8) - **(go\_fumpt)** comment out broken check by [@matdibu](https://github.com/matdibu) in [#668](jdx/hk#668) - **(yamllint)** enable strict mode by [@matdibu](https://github.com/matdibu) in [#673](jdx/hk#673) - respect ignore when recursing by [@thejcannon](https://github.com/thejcannon) in [#661](jdx/hk#661) - Deduplicate files in check-case-conflict to prevent false positives by [@safinn](https://github.com/safinn) in [#678](jdx/hk#678) - Fix building of nix flake wiwth the inclusion of git subomdules by [@jeffutter](https://github.com/jeffutter) in [#681](jdx/hk#681) ##### 🛡️ Security - add tone calibration to release notes prompt by [@jdx](https://github.com/jdx) in [#679](jdx/hk#679) - add opengraph meta tags by [@jdx](https://github.com/jdx) in [#685](jdx/hk#685) ##### 🔍 Other Changes - Use tmpdir for the tests by [@thejcannon](https://github.com/thejcannon) in [#677](jdx/hk#677) ##### 📦️ Dependency Updates - lock file maintenance by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#658](jdx/hk#658) - update anthropics/claude-code-action digest to [`b113f49`](jdx/hk@b113f49) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#684](jdx/hk#684) - update actions/checkout digest to [`de0fac2`](jdx/hk@de0fac2) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#683](jdx/hk#683) ##### New Contributors - [@jeffutter](https://github.com/jeffutter) made their first contribution in [#681](jdx/hk#681) - [@matdibu](https://github.com/matdibu) made their first contribution in [#673](jdx/hk#673) - [@safinn](https://github.com/safinn) made their first contribution in [#678](jdx/hk#678) - [@CallumKerson](https://github.com/CallumKerson) made their first contribution in [#659](jdx/hk#659) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

use tmpdir for the tests

7a3581e

gemini-code-assist Bot reviewed Feb 5, 2026

View reviewed changes

fix it

f2c6b8a

jdx merged commit cc2d55c into jdx:main Feb 9, 2026
16 checks passed

jdx mentioned this pull request Feb 9, 2026

chore: release v1.36.0 #657

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Use tmpdir for the tests#677

chore: Use tmpdir for the tests#677
jdx merged 2 commits intojdx:mainfrom
thejcannon:jcannon/tmpdir-the-tests

thejcannon commented Feb 5, 2026

Uh oh!

gemini-code-assist Bot commented Feb 5, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

thejcannon commented Feb 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

thejcannon commented Feb 5, 2026

Uh oh!

gemini-code-assist Bot commented Feb 5, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

thejcannon commented Feb 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants