Conversation
Summary of ChangesHello @jdx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request prepares the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request handles the release of v1.36.0, primarily by updating version strings across the codebase, including configuration, documentation, and source files. The changes are consistent with a release process. My review includes suggestions to improve maintainability by reducing hardcoded version numbers, which would make future releases less error-prone. I've also pointed out a potential copy-paste error in the changelog.
| @@ -1,5 +1,11 @@ | |||
| # Changelog | |||
|
|
|||
| ## [1.36.0](https://github.com/jdx/hk/compare/v1.35.0..v1.36.0) - 2026-02-01 | |||
| amends "package://github.com/jdx/hk/releases/download/v1.36.0/hk@1.36.0#/Config.pkl" | ||
| import "package://github.com/jdx/hk/releases/download/v1.36.0/hk@1.36.0#/Builtins.pkl" |
There was a problem hiding this comment.
To improve maintainability, consider using a variable for the version number in your documentation files. Hardcoding the version in multiple places makes releases more tedious and error-prone.
Since you are using VitePress, you could define the version in your VitePress config (e.g., in .vitepress/config.js) and then reference it in your markdown files, for example: v{{ $theme.version }}. This would centralize the version number and simplify future releases.
| Examples:\n\ | ||
| • amends \"pkl/Config.pkl\" (if vendored)\n\ | ||
| • amends \"package://github.com/jdx/hk/releases/download/v1.35.0/hk@1.35.0#/Config.pkl\"", | ||
| • amends \"package://github.com/jdx/hk/releases/download/v1.36.0/hk@1.36.0#/Config.pkl\"", |
There was a problem hiding this comment.
To improve maintainability and avoid having to update the version string in this error message for every release, consider constructing the URL dynamically using the crate version. This will prevent this file from being part of future release PRs, reducing the chance of errors.
You can achieve this by using crate::version::version() and a formatted string in the bail! macro, like this:
bail!(
"... amends \"package://github.com/jdx/hk/releases/download/v{version}/hk@{version}#/Config.pkl\"",
path.display(),
version = crate::version::version()
);f8e98d8 to
a73f5ef
Compare
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
7054da0 to
7ac2902
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
🚀 Features
--quietby @matdibu in #667--quietby @matdibu in #676🐛 Bug Fixes
tags instead of
in sea shanty by @jdx in 12e17f8
🛡️ Security
🔍 Other Changes
📦️ Dependency Updates
New Contributors
Note
Low Risk
Primarily a version bump and documentation/metadata regeneration; the only code change is an updated error message string.
Overview
Bumps
hkto v1.36.0, including updatingCargo.toml,Cargo.lock, and the generated CLI metadata (docs/cli/commands.json,hk.usage.kdl, and CLI docs pages).Updates documentation/examples to reference the new release package URLs (
v1.36.0) and documents the new--prflag acrosscheck/fix/runcommand docs. Also refreshes the Pkl config error message example insrc/config.rsto point at the v1.36.0 package URL.Written by Cursor Bugbot for commit 6f01057. This will update automatically on new commits. Configure here.