This repository was archived by the owner on Jul 13, 2025. It is now read-only.
Python: expose 'channel' as a property of the transport.#2396
Merged
Python: expose 'channel' as a property of the transport.#2396
Conversation
Permits app developers to e.g. perform explicit 'close' on channels for dynamically-created clients. See: googleapis/google-cloud-python#5523. Closes #2337.
5bd2c7d to
ce8ac96
Compare
Codecov Report
@@ Coverage Diff @@
## master #2396 +/- ##
=========================================
Coverage 86.72% 86.72%
Complexity 5241 5241
=========================================
Files 458 458
Lines 20867 20867
Branches 2252 2252
=========================================
Hits 18096 18096
Misses 1968 1968
Partials 803 803Continue to review full report at Codecov.
|
lukesneeringer
approved these changes
Nov 5, 2018
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 14, 2018
Includes fixes from these `gapic-generator` PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 14, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 14, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 14, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 14, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 14, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 14, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
This was referenced Nov 14, 2018
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 15, 2018
Closes #6500. Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 15, 2018
Closes #6498. Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396.
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 15, 2018
Closes #6496. Includes generated test changes. Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 15, 2018
* Firestore: pick up fixes to GAPIC generator. Closes #6497. Includes changes to generated tests. Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 * Fix overlong lines introduced in PR #6481.
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 19, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389) - googleapis/gapic-generator#2396 (for #5523 and dupes). Includes changes to generated tests. Closes #6502.
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 19, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389) - googleapis/gapic-generator#2396 (for #5523 and dupes). Includes changes to *all* generated tests. Removes now-spurious docstring fixups. Closes #6507.
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 19, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389) - googleapis/gapic-generator#2396 (for #5523 and dupes). Includes changes to generated tests. Removes now-spurious docstring fixups. Closes #6511.
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 19, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389) - googleapis/gapic-generator#2396 (for #5523 and dupes). Includes changes to generated tests. Closes #6512.
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 21, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Closes #6492.
This was referenced Nov 21, 2018
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 21, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Closes #6474.
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 21, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Closes #6475.
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 21, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Closes #6476.
tseaver
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 21, 2018
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Includes synth replacements to work around generated docstring issue: - googleapis/gapic-generator/issues/2449 Closes #6483.
tseaver
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 30, 2018
Includes fixes from these gapic-generator PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
busunkim96
pushed a commit
to googleapis/python-videointelligence
that referenced
this pull request
Dec 19, 2019
Includes fixes from these PRs: - googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389) - googleapis/gapic-generator#2396 (for #5523 and dupes). Includes changes to generated tests. Closes #6512.
busunkim96
pushed a commit
to googleapis/python-websecurityscanner
that referenced
this pull request
Jan 30, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Closes #6476.
busunkim96
pushed a commit
to googleapis/python-automl
that referenced
this pull request
Jan 31, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
crwilcox
pushed a commit
to googleapis/python-bigtable
that referenced
this pull request
Jan 31, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Closes #6492.
busunkim96
pushed a commit
to googleapis/python-container
that referenced
this pull request
Jan 31, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Includes synth replacements to work around generated docstring issue: - googleapis/gapic-generator/issues/2449 Closes #6483.
crwilcox
pushed a commit
to googleapis/python-firestore
that referenced
this pull request
Jan 31, 2020
* Firestore: pick up fixes to GAPIC generator. Closes #6497. Includes changes to generated tests. Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 * Fix overlong lines introduced in PR #6481.
crwilcox
pushed a commit
to googleapis/python-spanner
that referenced
this pull request
Jan 31, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389) - googleapis/gapic-generator#2396 (for #5523 and dupes). Includes changes to *all* generated tests. Removes now-spurious docstring fixups. Closes #6507.
busunkim96
pushed a commit
to googleapis/python-dlp
that referenced
this pull request
Jan 31, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396
crwilcox
pushed a commit
to googleapis/python-vision
that referenced
this pull request
Feb 1, 2020
Includes fixes from these PRs: - googleapis/gapic-generator#2407 - googleapis/gapic-generator#2396 Includes changes to generated tests. Closes #6475.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permits app developers to e.g. perform explicit 'close' on channels for
dynamically-created clients.
See: googleapis/google-cloud-python#5523.
Closes #2337.