Skip to content

[DO NOT MERGE] Container: new 'parent'/'name' arguments (non-breaking), timeouts, docstring updates via synth.#6483

Closed
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth-container
Closed

[DO NOT MERGE] Container: new 'parent'/'name' arguments (non-breaking), timeouts, docstring updates via synth.#6483
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth-container

Conversation

@yoshi-automation
Copy link
Copy Markdown
Contributor

@yoshi-automation yoshi-automation commented Nov 13, 2018

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Running generator for google/container/artman_container_v1.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:229601142daed005bf56fbaa21a02cf7aa0b261b57677d38306f8013e536de7a
Status: Image is up to date for googleapis/artman:latest
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/container-v1.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/container_v1/proto/cluster_service_pb2.py.
synthtool > Cleaned up 0 temporary directories.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2018
@tseaver tseaver added api: container Issues related to the Kubernetes Engine API API. codegen labels Nov 13, 2018
@tseaver tseaver changed the title [CHANGE ME] Re-generated container to pick up changes in the API or client library generator. Container: add new 'parent'/'name' arguments (non-breaking), docstring updates via synth. Nov 13, 2018
@tseaver tseaver changed the title Container: add new 'parent'/'name' arguments (non-breaking), docstring updates via synth. Container: new 'parent'/'name' arguments (non-breaking), timeouts, docstring updates via synth. Nov 13, 2018
tseaver
tseaver previously approved these changes Nov 13, 2018
View reviewed changes
@tseaver tseaver dismissed their stale review November 13, 2018 17:28

Docs build broken in CI

tseaver
tseaver suggested changes Nov 13, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updates to synth.py. See docs build breakage in CI.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 13, 2018
@tseaver tseaver changed the title Container: new 'parent'/'name' arguments (non-breaking), timeouts, docstring updates via synth. [DO NOT MERGE] Container: new 'parent'/'name' arguments (non-breaking), timeouts, docstring updates via synth. Nov 19, 2018
@tseaver tseaver mentioned this pull request Nov 21, 2018
Merged
@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Nov 21, 2018

Superseded by #6634.

tseaver added a commit that referenced this pull request Nov 21, 2018
@tseaver
Container: pick up fixes to GAPIC generator. (#6634)
57dafcb 
Includes fixes from these PRs:

- googleapis/gapic-generator#2407
- googleapis/gapic-generator#2396

Includes changes to generated tests.

Includes synth replacements to work around generated docstring issue:

- googleapis/gapic-generator/issues/2449

Closes #6483.
@tseaver tseaver deleted the autosynth-container branch November 21, 2018 16:45
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
Container: pick up fixes to GAPIC generator. (#6634)
6b7e348 
Includes fixes from these PRs:

- googleapis/gapic-generator#2407
- googleapis/gapic-generator#2396

Includes changes to generated tests.

Includes synth replacements to work around generated docstring issue:

- googleapis/gapic-generator/issues/2449

Closes #6483.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@tseaver tseaver tseaver requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: container Issues related to the Kubernetes Engine API API. cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshi-automation @tseaver @googlebot