Skip to content

[DO NOT MERGE] Oslogin to pick up changes in the API or client library generator.#6502

Closed
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth-oslogin
Closed

[DO NOT MERGE] Oslogin to pick up changes in the API or client library generator.#6502
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth-oslogin

Conversation

@yoshi-automation
Copy link
Copy Markdown
Contributor

@yoshi-automation yoshi-automation commented Nov 14, 2018

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/oslogin/artman_oslogin_v1.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:90f9d15e9bad675aeecd586725bce48f5667ffe7d5fc4d1e96d51ff34304815b
Status: Image is up to date for googleapis/artman:latest
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/os-login-v1.
synthtool > Replaced 'from google.cloud.oslogin.common import common_pb2' in google/cloud/oslogin_v1/proto/oslogin_pb2.py.
synthtool > Replaced 'from google.cloud.oslogin.common import common_pb2' in google/cloud/oslogin_v1/proto/oslogin_pb2_grpc.py.
synthtool > Cleaned up 0 temporary directories.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2018
@tseaver tseaver added codegen api: oslogin Issues related to the Cloud OS Login API API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Nov 19, 2018
tseaver
tseaver suggested changes Nov 19, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changes to generated tests.

@tseaver tseaver mentioned this pull request Nov 19, 2018
Merged
@tseaver tseaver changed the title [CHANGE ME] Re-generated oslogin to pick up changes in the API or client library generator. [DO NOT MERGE] Oslogin to pick up changes in the API or client library generator. Nov 19, 2018
@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Nov 19, 2018

Superseded by #6575.

tseaver added a commit that referenced this pull request Nov 19, 2018
@tseaver
Pick up fixes to GAPIC generator. (#6575)
4523af4 
Includes fixes from these PRs:

- googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389)
- googleapis/gapic-generator#2396 (for #5523 and dupes).

Includes changes to generated tests.

Closes #6502.
@tseaver tseaver deleted the autosynth-oslogin branch November 19, 2018 16:28
parthea pushed a commit that referenced this pull request Oct 31, 2023
@tseaver
Pick up fixes to GAPIC generator. (#6575)
0e0f2ff 
Includes fixes from these PRs:

- googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389)
- googleapis/gapic-generator#2396 (for #5523 and dupes).

Includes changes to generated tests.

Closes #6502.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@tseaver tseaver tseaver requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: oslogin Issues related to the Cloud OS Login API API. cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshi-automation @tseaver @googlebot