Skip to content

[DO NOT MERGE] Trace: pick up fixes to GAPIC generator.#6511

Closed
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth-trace
Closed

[DO NOT MERGE] Trace: pick up fixes to GAPIC generator.#6511
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth-trace

Conversation

@yoshi-automation
Copy link
Copy Markdown
Contributor

@yoshi-automation yoshi-automation commented Nov 14, 2018

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Running generator for google/devtools/cloudtrace/artman_cloudtrace_v1.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:90f9d15e9bad675aeecd586725bce48f5667ffe7d5fc4d1e96d51ff34304815b
Status: Image is up to date for googleapis/artman:latest
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/trace-v1.
synthtool > Replaced 'from google.devtools.cloudtrace_v1.proto import ' in google/cloud/trace_v1/proto/trace_pb2_grpc.py.
synthtool > Running generator for google/devtools/cloudtrace/artman_cloudtrace_v2.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:90f9d15e9bad675aeecd586725bce48f5667ffe7d5fc4d1e96d51ff34304815b
Status: Image is up to date for googleapis/artman:latest
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/trace-v2.
synthtool > Replaced 'from google.devtools.cloudtrace_v2.proto import ' in google/cloud/trace_v2/proto/tracing_pb2_grpc.py.
synthtool > Replaced 'from google.devtools.cloudtrace_v2.proto import ' in google/cloud/trace_v2/proto/tracing_pb2.py.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/trace_v2/proto/trace_pb2.py.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/trace_v2/proto/tracing_pb2.py.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/trace_v1/proto/trace_pb2.py.
synthtool > No replacements made in google/cloud/trace_v1/gapic/trace_service_client.py for pattern                 ::

, maybe replacement is not longer needed?
synthtool > Cleaned up 0 temporary directories.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2018
@tseaver tseaver added api: cloudtrace Issues related to the Cloud Trace API. codegen labels Nov 19, 2018
tseaver
tseaver suggested changes Nov 19, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Includes fixes from these PRs:

But, missing changes to generated tests.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 19, 2018
@tseaver tseaver changed the title [CHANGE ME] Re-generated trace to pick up changes in the API or client library generator. [DO NOT MERGE] Trace: pick up fixes to GAPIC generator. Nov 19, 2018
@tseaver tseaver mentioned this pull request Nov 19, 2018
Merged
@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Nov 19, 2018

Superseded by #6577.

tseaver added a commit that referenced this pull request Nov 19, 2018
@tseaver
Trace: pick up fixes to GAPIC generator. (#6577)
b8cf418 
Includes fixes from these PRs:

- googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389)
- googleapis/gapic-generator#2396 (for #5523 and dupes).

Includes changes to generated tests.

Removes now-spurious docstring fixups.

Closes #6511.
@tseaver tseaver deleted the autosynth-trace branch November 19, 2018 18:47
parthea pushed a commit that referenced this pull request Oct 22, 2023
@tseaver
Trace: pick up fixes to GAPIC generator. (#6577)
8a70f6b 
Includes fixes from these PRs:

- googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389)
- googleapis/gapic-generator#2396 (for #5523 and dupes).

Includes changes to generated tests.

Removes now-spurious docstring fixups.

Closes #6511.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@tseaver tseaver tseaver requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: cloudtrace Issues related to the Cloud Trace API. cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshi-automation @tseaver @googlebot