Skip to content

[DO NOT MERGE] Error_reporting: pick up fixes to GAPIC generator.#6496

Closed
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth-error_reporting
Closed

[DO NOT MERGE] Error_reporting: pick up fixes to GAPIC generator.#6496
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth-error_reporting

Conversation

@yoshi-automation
Copy link
Copy Markdown
Contributor

@yoshi-automation yoshi-automation commented Nov 14, 2018

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Running generator for google/devtools/clouderrorreporting/artman_errorreporting.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:90f9d15e9bad675aeecd586725bce48f5667ffe7d5fc4d1e96d51ff34304815b
Status: Image is up to date for googleapis/artman:latest
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/error-reporting-v1beta1.
synthtool > Replaced 'from google.devtools.clouderrorreporting_v1beta1.proto import ' in google/cloud/errorreporting_v1beta1/proto/error_stats_service_pb2.py.
synthtool > Replaced 'from google.devtools.clouderrorreporting_v1beta1.proto import ' in google/cloud/errorreporting_v1beta1/proto/report_errors_service_pb2.py.
synthtool > Replaced 'from google.devtools.clouderrorreporting_v1beta1.proto import ' in google/cloud/errorreporting_v1beta1/proto/error_group_service_pb2_grpc.py.
synthtool > Replaced 'from google.devtools.clouderrorreporting_v1beta1.proto import ' in google/cloud/errorreporting_v1beta1/proto/error_group_service_pb2.py.
synthtool > Replaced 'from google.devtools.clouderrorreporting_v1beta1.proto import ' in google/cloud/errorreporting_v1beta1/proto/error_stats_service_pb2_grpc.py.
synthtool > Replaced 'from google.devtools.clouderrorreporting_v1beta1.proto import ' in google/cloud/errorreporting_v1beta1/proto/report_errors_service_pb2_grpc.py.
synthtool > Replaced '\n        This endpoint accepts either an OAuth token, or an API key for\n        authentication. To use an API key, append it to the URL as the value of\n        a ``key`` parameter. For example:\n\n        \\.\\. raw:: html\n        <pre>POST .*\n' in google/cloud/errorreporting_v1beta1/gapic/report_errors_service_client.py.
synthtool > Replaced '\n        This endpoint accepts either an OAuth token, or an API key for\n        authentication. To use an API key, append it to the URL as the value of\n        a ``key`` parameter. For example:\n\n        \\.\\. raw:: html\n        <pre>POST .*\n' in google/cloud/errorreporting_v1beta1/gapic/transports/report_errors_service_grpc_transport.py.
synthtool > Cleaned up 0 temporary directories.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2018
@tseaver tseaver added api: clouderrorreporting Issues related to the Error Reporting API. codegen kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 14, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2018
@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 14, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2018
@tseaver tseaver changed the title [CHANGE ME] Re-generated error_reporting to pick up changes in the API or client library generator. [DO NOT MERGE] Error_reporting: pick up fixes in GAPIC generator. Nov 14, 2018
@tseaver tseaver mentioned this pull request Nov 14, 2018
Merged
@tseaver tseaver changed the title [DO NOT MERGE] Error_reporting: pick up fixes in GAPIC generator. [DO NOT MERGE] Error_reporting: pick up fixes to GAPIC generator. Nov 14, 2018
tseaver
tseaver suggested changes Nov 14, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Includes fixes from these PRs:

But doesn't include changes to generated tests.

@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Nov 14, 2018

Superseded by #6522.

tseaver added a commit that referenced this pull request Nov 15, 2018
@tseaver
Error reporting: pick up fixes to GAPIC generator. (#6522)
88b6ecc 
Closes #6496.

Includes generated test changes.

Includes fixes from these PRs:

- googleapis/gapic-generator#2407
- googleapis/gapic-generator#2396
@tseaver tseaver deleted the autosynth-error_reporting branch November 15, 2018 03:22
parthea pushed a commit that referenced this pull request Nov 24, 2025
@tseaver
Error reporting: pick up fixes to GAPIC generator. (#6522)
489e9b6 
Closes #6496.

Includes generated test changes.

Includes fixes from these PRs:

- googleapis/gapic-generator#2407
- googleapis/gapic-generator#2396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@tseaver tseaver tseaver requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: clouderrorreporting Issues related to the Error Reporting API. cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yoshi-automation @tseaver @googlebot @kokoro-team