Skip to content

events: fix missing application names from most used applications#6689

Merged
BeryJu merged 1 commit intomainfrom
events/fix-top_per_user
Aug 30, 2023
Merged

events: fix missing application names from most used applications#6689
BeryJu merged 1 commit intomainfrom
events/fix-top_per_user

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Aug 30, 2023

Details

closes #6686, closes #6688

Apparently at some point there was a bug in django that made KeyTextTransform return JSON even though, as the name says, it's supposed to cast everything to text, and hence we never noticed. Switching it out with a KeyTransform doesn't cast the value to anything and works as expected


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner August 30, 2023 10:15
@BeryJu BeryJu requested review from rissson and removed request for a team August 30, 2023 10:15
@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 3b37021
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64ef16de399bc50008a2f9bc

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.46%. Comparing base (8192b31) to head (3b37021).
⚠️ Report is 6025 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6689      +/-   ##
==========================================
- Coverage   92.48%   92.46%   -0.03%     
==========================================
  Files         561      561              
  Lines       27147    27148       +1     
==========================================
- Hits        25108    25103       -5     
- Misses       2039     2045       +6     
Flag Coverage Δ
e2e 51.58% <33.33%> (+0.06%) ⬆️
integration 26.51% <0.00%> (-0.01%) ⬇️
unit 89.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit b6a57ff into main Aug 30, 2023
@BeryJu BeryJu deleted the events/fix-top_per_user branch August 30, 2023 10:46
@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-events-fix-top_per_user-1693392107-3b37021
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-events-fix-top_per_user-1693392107-3b37021-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-events-fix-top_per_user-1693392107-3b37021

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-events-fix-top_per_user-1693392107-3b37021-arm64

Afterwards, run the upgrade commands from the latest release notes.

kensternberg-authentik added a commit that referenced this pull request Sep 1, 2023
* main: (22 commits)
  web/admin: fix ak-toggle-group for policy and blueprint uses (#6687)
  events: fix missing application names from most used applications (#6689)
  core: bump goauthentik.io/api/v3 from 3.2023061.13 to 3.2023081.1 (#6681)
  website: bump prettier from 3.0.2 to 3.0.3 in /website (#6683)
  website: bump postcss from 8.4.28 to 8.4.29 in /website (#6684)
  core: bump sentry-sdk from 1.29.2 to 1.30.0 (#6682)
  web: bump pyright from 1.1.324 to 1.1.325 in /web (#6685)
  web: bump API Client version (#6680)
  release: 2023.8.1
  website: bump 2023.8.1 release notes (#6678)
  root/revert persistent connections (#6677)
  blueprints: fix policy exception causing password stage to be skipped after upgrade (#6674)
  web/admin: fix version link to release notes (#6676)
  web: fix notification drawer scrolling (#6675)
  website/docs: fix typos (#6672)
  web: bump prettier from 3.0.2 to 3.0.3 in /web (#6671)
  website: remove enterprise waitlist (#6670)
  web: bump API Client version (#6669)
  release: 2023.8.0
  website: update 2023.8 release notes (#6666)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing application names under 'Apps with most usage'

2 participants