Skip to content

web: fix notification drawer scrolling#6675

Merged
BeryJu merged 1 commit intomainfrom
web/fix-notification-drawer-scrolling
Aug 29, 2023
Merged

web: fix notification drawer scrolling#6675
BeryJu merged 1 commit intomainfrom
web/fix-notification-drawer-scrolling

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Aug 29, 2023

Details

Fix vertical scrolling of notification drawer


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner August 29, 2023 21:45
@BeryJu BeryJu requested review from smilelyj and removed request for a team August 29, 2023 21:45
@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit da7e119
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64ee67640f2ede00086315d1
😎 Deploy Preview https://deploy-preview-6675--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.57% ⚠️

Comparison is base (bcf9a01) 92.50% compared to head (da7e119) 90.93%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6675      +/-   ##
==========================================
- Coverage   92.50%   90.93%   -1.57%     
==========================================
  Files         561      561              
  Lines       27146    27146              
==========================================
- Hits        25110    24683     -427     
- Misses       2036     2463     +427     
Flag Coverage Δ
e2e 51.54% <ø> (-<0.01%) ⬇️
integration ?
unit 89.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit ce0e1c1 into main Aug 29, 2023
@BeryJu BeryJu deleted the web/fix-notification-drawer-scrolling branch August 29, 2023 22:07
kensternberg-authentik added a commit that referenced this pull request Sep 1, 2023
* main: (22 commits)
  web/admin: fix ak-toggle-group for policy and blueprint uses (#6687)
  events: fix missing application names from most used applications (#6689)
  core: bump goauthentik.io/api/v3 from 3.2023061.13 to 3.2023081.1 (#6681)
  website: bump prettier from 3.0.2 to 3.0.3 in /website (#6683)
  website: bump postcss from 8.4.28 to 8.4.29 in /website (#6684)
  core: bump sentry-sdk from 1.29.2 to 1.30.0 (#6682)
  web: bump pyright from 1.1.324 to 1.1.325 in /web (#6685)
  web: bump API Client version (#6680)
  release: 2023.8.1
  website: bump 2023.8.1 release notes (#6678)
  root/revert persistent connections (#6677)
  blueprints: fix policy exception causing password stage to be skipped after upgrade (#6674)
  web/admin: fix version link to release notes (#6676)
  web: fix notification drawer scrolling (#6675)
  website/docs: fix typos (#6672)
  web: bump prettier from 3.0.2 to 3.0.3 in /web (#6671)
  website: remove enterprise waitlist (#6670)
  web: bump API Client version (#6669)
  release: 2023.8.0
  website: update 2023.8 release notes (#6666)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant