web/admin: fix ak-toggle-group for policy and blueprint uses#6687
Merged
web/admin: fix ak-toggle-group for policy and blueprint uses#6687
Conversation
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6687 +/- ##
==========================================
- Coverage 92.48% 92.37% -0.11%
==========================================
Files 561 561
Lines 27147 27147
==========================================
- Hits 25103 25073 -30
- Misses 2044 2074 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-web-admin-fix-ak-toggle-group-1693389809-aa5ec94
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sFor arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-web-admin-fix-ak-toggle-group-1693389809-aa5ec94-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-web-admin-fix-ak-toggle-group-1693389809-aa5ec94For arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-web-admin-fix-ak-toggle-group-1693389809-aa5ec94-arm64Afterwards, run the upgrade commands from the latest release notes. |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
kensternberg-authentik
added a commit
that referenced
this pull request
Sep 1, 2023
* main: (22 commits) web/admin: fix ak-toggle-group for policy and blueprint uses (#6687) events: fix missing application names from most used applications (#6689) core: bump goauthentik.io/api/v3 from 3.2023061.13 to 3.2023081.1 (#6681) website: bump prettier from 3.0.2 to 3.0.3 in /website (#6683) website: bump postcss from 8.4.28 to 8.4.29 in /website (#6684) core: bump sentry-sdk from 1.29.2 to 1.30.0 (#6682) web: bump pyright from 1.1.324 to 1.1.325 in /web (#6685) web: bump API Client version (#6680) release: 2023.8.1 website: bump 2023.8.1 release notes (#6678) root/revert persistent connections (#6677) blueprints: fix policy exception causing password stage to be skipped after upgrade (#6674) web/admin: fix version link to release notes (#6676) web: fix notification drawer scrolling (#6675) website/docs: fix typos (#6672) web: bump prettier from 3.0.2 to 3.0.3 in /web (#6671) website: remove enterprise waitlist (#6670) web: bump API Client version (#6669) release: 2023.8.0 website: update 2023.8 release notes (#6666) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
ak-toggle-group expects to have the
valuebe a string, but for the policy binding form and the blueprint instance form we were using numbers as types, which got cast to string and so never matched any of the checksAdditionally there were some imports missing and the PFBase css was missing so the font wasn't correct
cc @kensternberg-authentik
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)If applicable
make website)