Skip to content

blueprints: fix policy exception causing password stage to be skipped after upgrade#6674

Merged
BeryJu merged 2 commits intomainfrom
blueprints/fix-default-authentication-flow
Aug 29, 2023
Merged

blueprints: fix policy exception causing password stage to be skipped after upgrade#6674
BeryJu merged 2 commits intomainfrom
blueprints/fix-default-authentication-flow

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Aug 29, 2023

Details

closes #6673

due to changing defaults, after upgrading from some versions, a new default policy would be run at the wrong time causing it to fail, which would cause the password stage to get skipped

this fixes both the missing default value and also makes the policy more resilient to errors


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner August 29, 2023 21:29
@BeryJu BeryJu requested review from tanberry and removed request for a team August 29, 2023 21:29
@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 47d23d1
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64ee67e4efde860008305f7f

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the blueprints/fix-default-authentication-flow branch from 1387abc to 3767ba1 Compare August 29, 2023 21:34
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (bcf9a01) to head (3767ba1).
Report is 4985 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6674      +/-   ##
==========================================
- Coverage   92.49%   90.92%   -1.58%     
==========================================
  Files         561      561              
  Lines       27146    27146              
==========================================
- Hits        25110    24682     -428     
- Misses       2036     2464     +428     
Flag Coverage Δ
e2e 51.51% <ø> (-0.03%) ⬇️
integration ?
unit 89.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@esackbauer
Copy link

and also makes the policy more resilient to errors

Does that mean Authentik is still prone to timing attacks, just not so much anymore?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-blueprints-fix-default-authentication-flow-1693345415-47d23d1
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-blueprints-fix-default-authentication-flow-1693345415-47d23d1-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-blueprints-fix-default-authentication-flow-1693345415-47d23d1

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-blueprints-fix-default-authentication-flow-1693345415-47d23d1-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 1ffb7ef into main Aug 29, 2023
@BeryJu BeryJu deleted the blueprints/fix-default-authentication-flow branch August 29, 2023 22:08
kensternberg-authentik added a commit that referenced this pull request Sep 1, 2023
* main: (22 commits)
  web/admin: fix ak-toggle-group for policy and blueprint uses (#6687)
  events: fix missing application names from most used applications (#6689)
  core: bump goauthentik.io/api/v3 from 3.2023061.13 to 3.2023081.1 (#6681)
  website: bump prettier from 3.0.2 to 3.0.3 in /website (#6683)
  website: bump postcss from 8.4.28 to 8.4.29 in /website (#6684)
  core: bump sentry-sdk from 1.29.2 to 1.30.0 (#6682)
  web: bump pyright from 1.1.324 to 1.1.325 in /web (#6685)
  web: bump API Client version (#6680)
  release: 2023.8.1
  website: bump 2023.8.1 release notes (#6678)
  root/revert persistent connections (#6677)
  blueprints: fix policy exception causing password stage to be skipped after upgrade (#6674)
  web/admin: fix version link to release notes (#6676)
  web: fix notification drawer scrolling (#6675)
  website/docs: fix typos (#6672)
  web: bump prettier from 3.0.2 to 3.0.3 in /web (#6671)
  website: remove enterprise waitlist (#6670)
  web: bump API Client version (#6669)
  release: 2023.8.0
  website: update 2023.8 release notes (#6666)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker 2023.8.0 - login without password, just valid username

2 participants