web: fix application name not showing on admin dashboard#6686
Closed
web: fix application name not showing on admin dashboard#6686
Conversation
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
✅ Deploy Preview for authentik-storybook canceled.
|
05702d9 to
5b69e56
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #6686 +/- ##
==========================================
- Coverage 92.48% 92.47% -0.00%
==========================================
Files 561 561
Lines 27147 27147
==========================================
- Hits 25103 25102 -1
- Misses 2044 2045 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
5b69e56 to
2fd9f81
Compare
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-fix-application-name-in-dashboard-1693390499-2fd9f81
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sFor arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-fix-application-name-in-dashboard-1693390499-2fd9f81-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-fix-application-name-in-dashboard-1693390499-2fd9f81For arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-fix-application-name-in-dashboard-1693390499-2fd9f81-arm64Afterwards, run the upgrade commands from the latest release notes. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Since 2023.8, the application name is not showing on the admin dashboard anymore
This is due to the fact that the API endpoint used returns nested JSON:
[ { "application": "{\"pk\": \"87b69f323fc64435b181d1fc966cb939\", \"app\": \"authentik_core\", \"name\": \"Nextcloud\", \"model_name\": \"application\"}", "counted_events": 56, "unique_users": 3 } ]whereas it previously returned that
applicationkey expanded.This PR gets rid of the
applicationdata altogether and simply gives back the application name.Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)If applicable
make website)