Skip to content

web: Safari fixes merge branch#14181

Merged
GirlBossRush merged 3 commits intomainfrom
safari-fixes-merge-branch
Apr 24, 2025
Merged

web: Safari fixes merge branch#14181
GirlBossRush merged 3 commits intomainfrom
safari-fixes-merge-branch

Conversation

@GirlBossRush
Copy link
Contributor

@GirlBossRush GirlBossRush commented Apr 22, 2025 •
edited
Loading

Details

This PR combines #14140 and #14135 -- for ease of testing since each fix allows the page to render a bit more on Safari.

Also included...

  • A partial-fix for an issue where the admin overview page can trigger a crash loop.
  • The page layout now leans into Patternfly's grid, allowing for less jank during viewport resizing.
  • The grid layout allows for a follow up iteration to better handle permissions-based UI reflowing.
  • Cards with variable height content now show fewer scrollbars on desktop, tablet, and mobile.

Before

Screenshot 2025-04-22 at 20 20 39

image (1)

After

Screenshot 2025-04-23 at 06 42 45 Screenshot 2025-04-23 at 07 20 03 Screenshot 2025-04-23 at 07 20 38 Screenshot 2025-04-23 at 07 20 50

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@GirlBossRush GirlBossRush self-assigned this Apr 22, 2025
@GirlBossRush GirlBossRush requested a review from a team as a code owner April 22, 2025 18:15
@netlify
Copy link

netlify bot commented Apr 22, 2025 •
edited
Loading

✅ Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit f8f25a4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/680a437642079d0008dc5b7b
😎 Deploy Preview https://deploy-preview-14181--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Apr 22, 2025 •
edited
Loading

✅ Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit f8f25a4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/680a4376582c210008dc6e29

@codecov
Copy link

codecov bot commented Apr 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (e9822cd) to head (f8f25a4).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14181   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files         809      809           
  Lines       41533    41533           
=======================================
  Hits        38526    38526           
  Misses       3007     3007
Flag Coverage Δ
e2e 47.91% <ø> (+0.05%) ⬆️
integration 24.39% <ø> (ø)
unit 90.56% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025 •
edited
Loading

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-f8f25a47452709e6ef40045987f9cc17f1180076
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-f8f25a47452709e6ef40045987f9cc17f1180076

Afterwards, run the upgrade commands from the latest release notes.

@GirlBossRush GirlBossRush force-pushed the safari-fixes-merge-branch branch from baabb3b to e6a22c2 Compare April 23, 2025 15:07
kensternberg-authentik
kensternberg-authentik approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good and it's nice and clean. The scaling bug with the graphs has been fixed. I would recommend getting Jens's approval on the new layout, though.

@GirlBossRush GirlBossRush force-pushed the safari-fixes-merge-branch branch from 089f1e6 to e6a22c2 Compare April 24, 2025 13:17
@GirlBossRush GirlBossRush force-pushed the safari-fixes-merge-branch branch 3 times, most recently from f83b8a5 to 00eff98 Compare April 24, 2025 13:44
@GirlBossRush GirlBossRush force-pushed the safari-fixes-merge-branch branch from 00eff98 to f8f25a4 Compare April 24, 2025 13:58
@GirlBossRush GirlBossRush merged commit cf160f8 into main Apr 24, 2025
89 checks passed
@GirlBossRush GirlBossRush deleted the safari-fixes-merge-branch branch April 24, 2025 14:16
This was referenced Apr 24, 2025
Closed
Closed
rissson added a commit that referenced this pull request Apr 24, 2025
@rissson
Revert "web: Safari fixes merge branch (#14181)"
a41d458 
This reverts commit cf160f8.
rissson added a commit that referenced this pull request Apr 24, 2025
@rissson
Revert "web: Safari fixes merge branch (#14181)" (#14211)
3379566
kensternberg-authentik added a commit that referenced this pull request Apr 25, 2025
@kensternberg-authentik
Merge branch 'main' into dev
518e9e1 
* main:
  web: Safari fixes merge branch (#14181)
  website: bump the build group in /website with 9 updates (#14204)
  website: bump typescript from 5.8.2 to 5.8.3 in /website (#13786)
  lifecycle/migrate: fix migration failing if killed during first startup (#14207)
  core, web: update translations (#14203)
  lifecycle/aws: bump aws-cdk from 2.1010.0 to 2.1012.0 in /lifecycle/aws (#14205)
  website/integrations: improves netbird documentation (#14191)
  website/docs: updated user count info (#14186)
  website/docs: rearranged brands docs (#14116)
  website: integrations: apache guacamole: remove redirect URI comments (#14113)
GirlBossRush added a commit that referenced this pull request May 2, 2025
@GirlBossRush
Reapply "web: Safari fixes merge branch (#14181)"
ddc4a09 
This reverts commit a41d458.
@GirlBossRush GirlBossRush mentioned this pull request May 2, 2025
Merged
6 tasks
GirlBossRush added a commit that referenced this pull request May 2, 2025
@GirlBossRush
Revert-revert: Safari fixes (#14331)
61a26c0 
* Reapply "web: Safari fixes merge branch (#14181)"

This reverts commit a41d458.

* web: Fix brand preference order. Adjust header height.
@GirlBossRush GirlBossRush mentioned this pull request May 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kensternberg-authentik kensternberg-authentik kensternberg-authentik approved these changes

Assignees

@GirlBossRush GirlBossRush

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GirlBossRush @kensternberg-authentik