Skip to content

Revert-revert: Safari fixes#14331

Merged
GirlBossRush merged 2 commits intomainfrom
safari-fixes-v2
May 2, 2025
Merged

Revert-revert: Safari fixes#14331
GirlBossRush merged 2 commits intomainfrom
safari-fixes-v2

Conversation

@GirlBossRush
Copy link
Contributor

Details

See #14181

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@GirlBossRush GirlBossRush self-assigned this May 2, 2025
@GirlBossRush GirlBossRush requested a review from a team as a code owner May 2, 2025 13:22
@netlify
Copy link

netlify bot commented May 2, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 709fdcd
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6814c72a375cff000840af82

@netlify
Copy link

netlify bot commented May 2, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 709fdcd
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6814c72ad1842200081c870b
😎 Deploy Preview https://deploy-preview-14331--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.77%. Comparing base (5c9e97e) to head (709fdcd).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14331      +/-   ##
==========================================
+ Coverage   92.70%   92.77%   +0.06%     
==========================================
  Files         809      809              
  Lines       41533    41533              
==========================================
+ Hits        38504    38531      +27     
+ Misses       3029     3002      -27     
Flag Coverage Δ
e2e 47.90% <ø> (+0.13%) ⬆️
integration 24.39% <ø> (ø)
unit 90.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-709fdcd2fcdb804100476f2a77cc5563f33f05f5
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-709fdcd2fcdb804100476f2a77cc5563f33f05f5

Afterwards, run the upgrade commands from the latest release notes.

Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatter didn't change the one-liner, so that needs to go into prettier if it can.

if (!this.settings) {
return nothing;
}
if (!this.settings) return nothing;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure our prettier setting always add braces. Has this been formatted?

@GirlBossRush GirlBossRush merged commit 61a26c0 into main May 2, 2025
95 checks passed
@GirlBossRush GirlBossRush deleted the safari-fixes-v2 branch May 2, 2025 19:26
BeryJu added a commit that referenced this pull request May 10, 2025
#14331

removes 2 unneeded API calls

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request May 11, 2025
* core: include all sentry headers

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* remove spotlight patch we dont need anymore

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* always trace in debug

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* init sentry earlier

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* re-add light interface

#14331

removes 2 unneeded API calls

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* sentry integrated router

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* use new Sentry middleware to propagate headers

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix missing baggage

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* cleanup logs

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* use sanitized URLs for logging/tracing

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants