Skip to content

root: improve sentry distributed tracing#14468

Merged
BeryJu merged 10 commits intomainfrom
root/improve-sentry-distributed-tracing
May 11, 2025
Merged

root: improve sentry distributed tracing#14468
BeryJu merged 10 commits intomainfrom
root/improve-sentry-distributed-tracing

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented May 10, 2025

Details

Implement better routing integration based on getsentry/sentry-javascript#11445

Currently doesn't work correctly only first page load of an interface as the initial transaction is started from django, then needs to be continued in JS and then continued back in django, only after navigating within the SPA this is picked up correctly.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

BeryJu added 7 commits May 11, 2025 00:11
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
#14331

removes 2 unneeded API calls

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners May 10, 2025 22:25
@netlify
Copy link

netlify bot commented May 10, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit dbb84c3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/681feafc8a197a0009b7ebf3
😎 Deploy Preview https://deploy-preview-14468--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented May 10, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit dbb84c3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/681feafcb6d49f00087f3424

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@codecov
Copy link

codecov bot commented May 10, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.71%. Comparing base (7d2aa43) to head (dbb84c3).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/lib/sentry.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14468      +/-   ##
==========================================
+ Coverage   92.44%   92.71%   +0.27%     
==========================================
  Files         809      809              
  Lines       41535    41540       +5     
==========================================
+ Hits        38397    38514     +117     
+ Misses       3138     3026     -112     
Flag Coverage Δ
e2e 47.83% <90.90%> (+1.23%) ⬆️
integration 24.39% <45.45%> (+<0.01%) ⬆️
unit 90.56% <81.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-dbb84c34bdaeee69d0d8440a2f57eae4fad4bc86
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-dbb84c34bdaeee69d0d8440a2f57eae4fad4bc86

Afterwards, run the upgrade commands from the latest release notes.

BeryJu added 2 commits May 11, 2025 02:08
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit f11ba94 into main May 11, 2025
90 of 91 checks passed
@BeryJu BeryJu deleted the root/improve-sentry-distributed-tracing branch May 11, 2025 00:40
kensternberg-authentik added a commit that referenced this pull request May 22, 2025
* main: (60 commits)
  website: bump the build group in /website with 6 updates (#14502)
  core: remove `OldAuthenticatedSession` content type (#14507)
  core: bump msgraph-sdk from 1.29.0 to 1.30.0 (#14503)
  core: bump twilio from 9.6.0 to 9.6.1 (#14505)
  core: bump psycopg[c,pool] from 3.2.8 to 3.2.9 (#14504)
  enterprise: fix expired license's users being counted (#14451)
  website/integrations: fix missing closing brace for semaphore (#14467)
  tests/e2e: Add E2E tests for Flow SFE (#14484)
  website: bump semver from 7.7.1 to 7.7.2 in /website (#14491)
  core: bump django from 5.1.8 to 5.1.9 (#14483)
  core: bump psycopg[c,pool] from 3.2.7 to 3.2.8 (#14481)
  core: bump sentry-sdk from 2.27.0 to 2.28.0 (#14482)
  root: pin package version in pyproject for dependabot (#14469)
  core: fix session migration when old session can't be loaded (#14466)
  root: temporarily deactivate database pool option (#14443)
  website: bump the build group in /website with 3 updates (#14475)
  website/docs: stages: fix-typo (#14477)
  website/docs: Update Kubernetes Bootstrap Instructions (#14471)
  root: improve sentry distributed tracing (#14468)
  Revert "web/admin: fix enterprise menu display" (#14458)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant