Skip to content

web: Fix issue where references to Lit SSR break page styles.#14135

Closed
GirlBossRush wants to merge 1 commit intomainfrom
fix-shared-entrypoints
Closed

web: Fix issue where references to Lit SSR break page styles.#14135
GirlBossRush wants to merge 1 commit intomainfrom
fix-shared-entrypoints

Conversation

@GirlBossRush
Copy link
Contributor

@GirlBossRush GirlBossRush commented Apr 17, 2025

Details

This PR addresses an issue that stems from use of Lit's Node.js exclusive SSR package on the front-end, causing page styles not to load. This occurs on the Captcha stage, or if a flow footer includes links.

⚠️ Requires testing of Captcha flow before approving

Screenshot 2025-04-17 at 19 48 40

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@GirlBossRush GirlBossRush added the bug Something isn't working label Apr 17, 2025
@GirlBossRush GirlBossRush self-assigned this Apr 17, 2025
@GirlBossRush GirlBossRush requested a review from a team as a code owner April 17, 2025 18:00
@netlify
Copy link

netlify bot commented Apr 17, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 4f98c21
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6807dbf4d91f7800085e00b4

@netlify
Copy link

netlify bot commented Apr 17, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 4f98c21
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6807dbf4ff1f3a00088ffc7f
😎 Deploy Preview https://deploy-preview-14135--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GirlBossRush GirlBossRush force-pushed the fix-shared-entrypoints branch from dcce203 to 04bd8c3 Compare April 17, 2025 18:04
@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.81%. Comparing base (fffcb00) to head (4f98c21).
Report is 26 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14135      +/-   ##
==========================================
+ Coverage   92.75%   92.81%   +0.06%     
==========================================
  Files         808      808              
  Lines       41419    41419              
==========================================
+ Hits        38418    38445      +27     
+ Misses       3001     2974      -27     
Flag Coverage Δ
e2e 47.86% <ø> (+0.13%) ⬆️
integration 24.25% <ø> (ø)
unit 90.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-4f98c21f42d3cce1a48d0aa5aed8e30f7aa71b5e
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-4f98c21f42d3cce1a48d0aa5aed8e30f7aa71b5e

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu changed the title Fix issue where references to Lit SSR break page styles. web: Fix issue where references to Lit SSR break page styles. Apr 18, 2025
@GirlBossRush GirlBossRush force-pushed the fix-shared-entrypoints branch 2 times, most recently from 727ef9e to a520d08 Compare April 22, 2025 14:12
Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes the flow rendering issues but this PR shouldn't include changes to the navbar/other commits

@GirlBossRush GirlBossRush force-pushed the fix-shared-entrypoints branch from a520d08 to 6682a47 Compare April 22, 2025 18:00
@GirlBossRush GirlBossRush force-pushed the fix-shared-entrypoints branch from 6682a47 to 4f98c21 Compare April 22, 2025 18:12
@GirlBossRush
Copy link
Contributor Author

Resolved in #14181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants