Skip to content

web/admin: Fix Safari out-of-memory crash#14140

Closed
GirlBossRush wants to merge 1 commit intomainfrom
safari-crash-fix
Closed

web/admin: Fix Safari out-of-memory crash#14140
GirlBossRush wants to merge 1 commit intomainfrom
safari-crash-fix

Conversation

@GirlBossRush
Copy link
Contributor

@GirlBossRush GirlBossRush commented Apr 17, 2025

Details

This PR addresses an issue where Safari crashes when viewing the Admin interface. The fix is a combination of state handling and reworking of the layout to avoid cyclical changes during page resizing.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@GirlBossRush GirlBossRush self-assigned this Apr 17, 2025
@GirlBossRush GirlBossRush requested a review from a team as a code owner April 17, 2025 20:42
@netlify
Copy link

netlify bot commented Apr 17, 2025 •
edited
Loading

✅ Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 76c3c7d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6807dbe3df470e000850cd26
😎 Deploy Preview https://deploy-preview-14140--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Apr 17, 2025 •
edited
Loading

✅ Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 76c3c7d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6807dbe35b90cd0008658576
😎 Deploy Preview https://deploy-preview-14140--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (fffcb00) to head (76c3c7d).
Report is 26 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14140      +/-   ##
==========================================
+ Coverage   92.75%   92.80%   +0.05%     
==========================================
  Files         808      808              
  Lines       41419    41419              
==========================================
+ Hits        38418    38440      +22     
+ Misses       3001     2979      -22
Flag Coverage Δ
e2e 47.81% <ø> (+0.07%) ⬆️
integration 24.25% <ø> (ø)
unit 90.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025 •
edited
Loading

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-76c3c7d9687e06fe2d48c5b63335930ced7296bf
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-76c3c7d9687e06fe2d48c5b63335930ced7296bf

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu changed the title Admin Interface: Fix Safari out-of-memory crash web/admin: Fix Safari out-of-memory crash Apr 18, 2025
@GirlBossRush GirlBossRush force-pushed the safari-crash-fix branch 2 times, most recently from 9ba1d39 to 5213b15 Compare April 22, 2025 12:56
BeryJu
BeryJu requested changes Apr 22, 2025
View reviewed changes
Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new navbar there's layout shifts depending on if the page header has a subtitle or not

also breaks the layout with this not being aligned
image

@GirlBossRush GirlBossRush mentioned this pull request Apr 22, 2025
Merged
6 tasks
@GirlBossRush
Copy link
Contributor Author

GirlBossRush commented Apr 24, 2025

Resolved in #14181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BeryJu BeryJu BeryJu requested changes

@kensternberg-authentik kensternberg-authentik Awaiting requested review from kensternberg-authentik

Assignees

@GirlBossRush GirlBossRush

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GirlBossRush @BeryJu