website: integrations: apache guacamole: remove redirect URI comments#14113
Conversation
Self-evident. + Just follow the docs tbh
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14113 +/- ##
==========================================
+ Coverage 92.76% 92.82% +0.06%
==========================================
Files 799 809 +10
Lines 41230 41561 +331
==========================================
+ Hits 38245 38581 +336
+ Misses 2985 2980 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| openid-issuer=https://authentik.company/application/o/<your-slug>/ | ||
| openid-jwks-endpoint=https://authentik.company/application/o/<your-slug>/jwks/ | ||
| openid-redirect-uri=https://guacamole.company/ # This must match the Redirect URI set in authentik (Including trailing slash). | ||
| openid-redirect-uri=https://guacamole.company/. |
There was a problem hiding this comment.
| openid-redirect-uri=https://guacamole.company/. | |
| openid-redirect-uri=https://guacamole.company/ |
There was a problem hiding this comment.
Oooof good catch on that left-over punctuation, thanks @BeryJu !
I think we should leave the helpful Notes about making sure that the value matches the Redirect URI, and that the trailing slash is important. Why would we NOT want to include that helpful info? (Though we do need to make them match.)
Co-authored-by: Jens L. <jens@beryju.org> Signed-off-by: Dominic R <dominic@sdko.org>
tanberry
left a comment
There was a problem hiding this comment.
Thanks @dominic-r for this PR. As you suggested, let;'s find a common place to document that theRedirect URI needs to match, and the trailing slash is necessary.
* main: web: Safari fixes merge branch (#14181) website: bump the build group in /website with 9 updates (#14204) website: bump typescript from 5.8.2 to 5.8.3 in /website (#13786) lifecycle/migrate: fix migration failing if killed during first startup (#14207) core, web: update translations (#14203) lifecycle/aws: bump aws-cdk from 2.1010.0 to 2.1012.0 in /lifecycle/aws (#14205) website/integrations: improves netbird documentation (#14191) website/docs: updated user count info (#14186) website/docs: rearranged brands docs (#14116) website: integrations: apache guacamole: remove redirect URI comments (#14113)
Details
REPLACE ME
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)