Conversation
PB-111: Update geoblocks/mapfishprint to v0.2.11
Some GPX file might not have metadata and it is ok to have it null. Due to this GPX file without metadata could not be loaded correctly. When no metadata was present, even if the file was a local file, the load gpx data plugin was triggered. On a deployment we could see an error on HTTP where the plugin tried to load GPX file on https://sys-map.dev.bgdi.ch/FILE_NAME while on localhost it tried to do on localhost which gave a differant answer. So this triggered some weird bug. Now we allow GPX without metadata and only trigger the GPX load plugin when no data is present regardless of the metadata Also make sure to set the layer error in case of GPX load failure
Fix GPX local file import
…b, refactor later).
PB-398: Improve print UI user feedback
Issue : When selecting a drawing feature outside of the drawing mode, an error log would appear in the console explaining there were no coordinates. Fix : We use 'getCoordinates()' instead of 'coordinates' in the map interactions composable.
When creating a feature, if the coordinates are undefined, we set them to null.
…rawing-feature PB-404 bugfix: removing error on drawing selection
This service returned a HTTP 400.
PB-406: Updated canton Bern WMS urls
- Moved the code to composition api. - Added copy button to copy the content of the iframe example - On input click select the whole input, which make easier to copy
PB-393: Added copy button for embed iframe example
Passing run #1765 ↗︎Details:
Review all test suite changes for PR #787 ↗︎ |
|||||||||||||||
When entering in the search bar regex special characters the search bar could crash especially when entering `(` or `)`.
When closing the search bar result we focus on the input in order to be able to directly change the input again. When selecting a result entry we then close the results but also focus on the search input. Now the ESC key is a toggling result and when pressing enter on the search input we jump to the first result (opening the result if needed)
During e2e tests of the search bar, the console had errors due to invalid search layer mocking response.
When removing the swisssearch from the url or when removing its value, a null value was set in the store which make a crash (happened during e2e tests). Now we are using the parameter default value
The layer parameter in this case is a string and not an object
PB-396: Updated search bar e2e tests
LukasJoss
approved these changes
Apr 16, 2024
PB-360: Remove circular reference and unused properties from KML layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link