PB-404 bugfix: removing error on drawing selection#781
Merged
Conversation
Passing run #1737 ↗︎
Details:
Review all test suite changes for PR #781 ↗︎ |
|||||||||||||||
LukasJoss
reviewed
Apr 12, 2024
Contributor
LukasJoss
left a comment
There was a problem hiding this comment.
There is another instance where this bug occurs, when you go to drawing mode and place a marker:
When dragging the marker on the map in useDrawingModeInteraction.composable.js in the function onAddFeature there was
args.coordinates = null in a earlier version of the code, now it is undefined and thus fails.
15cc7d1 to
786b65b
Compare
LukasJoss
approved these changes
Apr 15, 2024
Issue : When selecting a drawing feature outside of the drawing mode, an error log would appear in the console explaining there were no coordinates. Fix : We use 'getCoordinates()' instead of 'coordinates' in the map interactions composable.
When creating a feature, if the coordinates are undefined, we set them to null.
786b65b to
8deb5fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : When selecting a drawing feature outside of the drawing mode, an error log would appear in the console explaining there were no coordinates.
Second Issue : when creating a drawing feature, an error log would appear in the console log explaining the same issue
Fix : We use 'getCoordinates()' instead of 'coordinates' in the map interactions composable.
Second Fix : when creating a Feature with no coordinates (undefined), we set them to null in the constructor.
Test link