PB-360: Remove circular reference and unused properties from KML layer.#761
PB-360: Remove circular reference and unused properties from KML layer.#761ismailsunni merged 6 commits intodevelopfrom
Conversation
Passing run #1758 ↗︎
Details:
Review all test suite changes for PR #761 ↗︎ |
|||||||||||||||
ltshb
left a comment
There was a problem hiding this comment.
I think it would be better to use the Customizer to remove those properties, see https://geoblocks.github.io/mapfishprint/docs/classes/BaseCustomizer.default.html#feature
ltshb
left a comment
There was a problem hiding this comment.
I've got failures in the console when printing a kml with a measure,
And also they was no error feedback, so without opening the console we could not see any error; You can use this shortlink to reproduce the issue
f333f47 to
7e790f4
Compare
|
@ismailsunni I allow myself to rebase and if it works I'll merge this, as I will work on an issue that might enter in conflict with this work. |
b0001f0 to
3a5fe1f
Compare
3a5fe1f to
43991cc
Compare
c39b35b to
96e0161
Compare
ltshb
left a comment
There was a problem hiding this comment.
Code looks good, however I found another issue (that could be fixed in a separate PR). For the KML measure, the total distance is not printed, like on the old viewer:
-
old viewer
-
new viewer
|
Also on the old viewer the drawing looks better (smaller lines) as on the new one that have thicker lines bolder text |
Test link
The geoblocks/mapfishprint is able to create the print specification with KML layer. Unfortunately, in mapviewer, there is a circular reference make it not possible to stringify the print specification object. The properties is removed as it's not used in the printing.
There is also another property (
editableFeature) that make mapfishprint throws an error.Sample print result:
Test link