Merged
Conversation
Passing run #1724 ↗︎
Details:
Review all test suite changes for PR #769 ↗︎ |
|||||||||||||||
8242877 to
c3ee672
Compare
hansmannj
reviewed
Apr 8, 2024
src/modules/i18n/locales/de.json
Outdated
| "duplicate_layer": "Karte duplizieren" | ||
| "duplicate_layer": "Karte duplizieren", | ||
| "feedback_empty_warning": "Die Berichtsnachricht darf nicht leer sein", | ||
| "operation_successful": "Erfolg! ", |
Member
There was a problem hiding this comment.
Is the extra whitespace at the end intentional? Or might it break some formatting?
Contributor
There was a problem hiding this comment.
I believe this might be a whitespace that was unseen in the google sheets.
ltkum
approved these changes
Apr 9, 2024
Contributor
ltkum
left a comment
There was a problem hiding this comment.
I would remove the extra whitespace, but apart from that LGTM and everything seems to be working as expected.
src/modules/i18n/locales/de.json
Outdated
| "duplicate_layer": "Karte duplizieren" | ||
| "duplicate_layer": "Karte duplizieren", | ||
| "feedback_empty_warning": "Die Berichtsnachricht darf nicht leer sein", | ||
| "operation_successful": "Erfolg! ", |
Contributor
There was a problem hiding this comment.
I believe this might be a whitespace that was unseen in the google sheets.
73a23af to
31e1fad
Compare
Now provide a success, aborted or failure feedback
31e1fad to
686448f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now provide a success, aborted or failure feedback
NOTE currently the failure feedback can be tested using a KML layer with a measure which is currently failing.
Test link