Merged
Conversation
Some GPX file might not have metadata and it is ok to have it null. Due to this GPX file without metadata could not be loaded correctly. When no metadata was present, even if the file was a local file, the load gpx data plugin was triggered. On a deployment we could see an error on HTTP where the plugin tried to load GPX file on https://sys-map.dev.bgdi.ch/FILE_NAME while on localhost it tried to do on localhost which gave a differant answer. So this triggered some weird bug. Now we allow GPX without metadata and only trigger the GPX load plugin when no data is present regardless of the metadata Also make sure to set the layer error in case of GPX load failure
Passing run #1474 ↗︎
Details:
Review all test suite changes for PR #762 ↗︎ |
|||||||||||||||
ismailsunni
approved these changes
Apr 4, 2024
Contributor
ismailsunni
left a comment
There was a problem hiding this comment.
LGTM, tested locally 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some GPX file might not have metadata and it is ok to have it null. Due to this GPX file without metadata could not be loaded correctly. When no metadata was present, even if the file was a local file, the load gpx data plugin was triggered. On a deployment we could see an error on HTTP where the plugin tried to load GPX file on https://sys-map.dev.bgdi.ch/FILE_NAME while on localhost it tried to do on localhost which gave a differant answer.
So this triggered some weird bug. Now we allow GPX without metadata and only trigger the GPX load plugin when no data is present regardless of the metadata
Also make sure to set the layer error in case of GPX load failure
Also Avoid unnecessary store dispatch in layers plugins
Test link