PB-393: Added copy button for embed iframe example#784
Merged
Conversation
Passing run #1744 ↗︎
Details:
Review all test suite changes for PR #784 ↗︎ |
|||||||||||||||
b21ec72 to
49df205
Compare
ltkum
approved these changes
Apr 15, 2024
Contributor
ltkum
left a comment
There was a problem hiding this comment.
Everything looks good to me. I think once you remove the comment leftover in the code, you are good to go and merge :)
| const embedInput = ref(null) | ||
| const showEmbedSharing = ref(false) | ||
| const showPreviewModal = ref(false) | ||
| // const EmbedSizes = ref(null) |
Contributor
There was a problem hiding this comment.
I suspect this is a leftover from a previous version
49df205 to
5dbb940
Compare
- Moved the code to composition api. - Added copy button to copy the content of the iframe example - On input click select the whole input, which make easier to copy
5dbb940 to
f6560b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link