Conversation
Make sure that new empty drawing are not saved but that existing modified are saved even if empty.
When closing the drawing menu without creating any drawing an empty kml was created and added to the menu in the map displayed. The saveKml event was called two many times, now it is only called when the drawing effectively changes. I also renamed some function names to be more explicit.
This test when done manually works but failed on CY probably due to a bug in the complex kmlIds management. This should be fixed by BGDIINF_SB-2729.
BGDIINF_SB-2668: Fixed empty drawing being saved and displayed in menu
Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/ljharb/qs/releases) - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.5.2...v6.5.3) --- updated-dependencies: - dependency-name: qs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bump qs from 6.5.2 to 6.5.3
This allow more place for the data and avoid truncating the what3words.
The tippy constructor returns an array of matched target and therefore we need to call the destroy to all array element.
Use copy icon for coordinates in position popup
Removed comment probably added for local testing.
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…uri-component-0.2.2 Bump decode-uri-component from 0.2.0 to 0.2.2
When creating a KML add the author version. Added get KML metadata from backend API helper
Before when the from the backend failed you couldn't close the drawing menu and the error status was not displayed. Also when an error happened outside the toggling of the show drawing menu, the exception was not catch. Now we simply set the status to ERROR and re-trigger an update later on.
BGDIINF_SB-2729: Added multiple KML edit and simplify KML drawing logic
Updating doc regarding app deployment
Not to disable the drawing menu we need to use the click:header event instead of click. The click event will be fired even if disabled while the click:header not.
As long as we are not live on `map.geo.admin.ch` don't allow to edit kml files created by the legacy viewer
…with new translation
BGDIINF_SB-2716: Don't allow to edit legacy kml files
Now if the loading of the KML failed in the drawing mode, we remove the kml layer as it is not selectable and we print an error message. The loading of the kml to translate it to a drawing will be automatically retried. In case of error we also display an error message at the same place as for saving error. Those errors message are also now displayed in red. Also renamed the savingStatus to drawingState which refer more to a drawing state to make the code clearer as it is also used to check if any modification on the drawing has been done. Improved the error handling and user experience in case of network failure.
…min-id-part-2 BGDIINF_SB-2733: Removed drawing adminId from url and open drawing mode automatically
Pipe characters are an issue on some external tools like JIRA. Moreover they are not allowed in URL spec.1
BGDIINF_SB-2750: Encode `|` in url
Sometimes for an unknown reason we have to set `{force: true}` on click() in
cypress otherwise cypress return an errors saying that the component is not
visible also it is visible.
Now we make sure before the click({force: true}) that the component is visible.
BGDIINF_SB-2182: Fixed E2E tests issue with `click({force: true})`
The language toolbar from the header did not disapeared on IOS devices which also prevent displaying the menu button. Some devices like IOS and gnome web browser doesn't support `or` in css media queries (`or` is an alias for `,` which has been introduced by Media Queries Level 4)
…phone BGDIINF_SB-2751: Fixed language menu on IOS devices
Give the user the opportunity to give a feedback on the application and to get additional informations about the project (CMS link)
feat_BGDIINF_SB-2666: adding a feedback and link to CMS buttons
So that it catches more the attention compared to the give information link. Also refactoring a bit the way we define links for the header, as we do many time the same look and feel there's now a dedicated component for such links.
Changing info button/link name (not really related to feedback) Changing the selected prop into primary/secondary in HeaderLink Boldening the text of the "Give feedback" text to let it be more visible
…utton_in_red BGDIINF_SB-2674 : change Give Feedback button color to red
Added the KML external disclaimer. Also now on click of an external layer (kml or external layer) a modal window with a data disclaimer is shown.
…con-3 BGDIINF_SB-2747: Add KML disclaimer icon and external disclaimer warning
that enables the user to rate his experience with a 5 star scale, and write his message directly in the UI (instead of letting him write it in his email editor). Also fixing a bug on tablet layout where the links were not rendered properly in the menu/settings section, as the UI was still considered being in desktop mode, thus the feedback and more info buttons were still rendered as links.
Send feedback to the backend, also simplifying the UI the user uses to send feedback
The user now can see if his request to send a feedback was successful or not, and also cannot send more than once the same feedback (but if he closes the form, he can now start a new feedback)
enlarging a little bit the modal component on mobile adding some extra height to the text area in the feedback form changing the fail text to something more specific better handling of error in the process of sending the feedback (KML loading error or short link generation error) changing the feedback API file so that rating (and max rating) are optional, so that we can use the same endpoint in the future for the "Report a problem" feature
while sending a feedback : fallback to sending full URL if the short link couldn't be generated
as there's some CSS glitch on iOS where the colour stays active even when the class "checked" has been removed. Meaning the user has the feeling that something is selected, but the "Send" button is disabled.
BGDIINF_SB-2764 : add feedback form
Update libs
ltshb
approved these changes
Feb 2, 2023
Contributor
|
@pakb perso je ferai un minor pour MVP et un major pour le real go live |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MVP release 🎉