BGDIINF_SB-2747: Add KML disclaimer icon and external disclaimer warning#362
Merged
BGDIINF_SB-2747: Add KML disclaimer icon and external disclaimer warning#362
Conversation
ddb7750 to
4f8017c
Compare
davidoesch
reviewed
Jan 30, 2023
Contributor
davidoesch
left a comment
There was a problem hiding this comment.
The modal window is really very heavy , It is not a warning as modal window, it is more like: you did something really bad... Therefore I would go for #360
Contributor
Author
|
@davidoesch what about this
My preference goes for 1. |
Added the KML external disclaimer. Also now on click of an external layer (kml or external layer) a modal window with a data disclaimer is shown.
4f8017c to
b786382
Compare
Contributor
|
Number one: proceed as discussed today |
1 task
pakb
approved these changes
Feb 1, 2023
Contributor
pakb
left a comment
There was a problem hiding this comment.
Looking good!
Way better this way, it still looks like you have to watch out for something, but not like you just had a critical error with the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the KML external disclaimer.
Also now on click of an external layer (kml or external layer) a modal window
with a data disclaimer is shown.
This PR replace #360, which had the data disclaimer warning in the tooltip instead of in a modal. The disadvantage is that tooltip are more designed and useful for short text. It is difficult on mobile to have tooltip that don't bother the user but stay long enough for reading.
Test link with external layer mf-geoadmin3 syntax
Test link