Conversation
5c158da to
e875b58
Compare
e875b58 to
7f6042c
Compare
|
@pakb it is ready for a first review although I might change the tippy behavior to improve user experience next week. |
pakb
left a comment
There was a problem hiding this comment.
looking good so far, a couple improvements / questions
| getExternalDisclaimerPopupContent() { | ||
| return this.$i18n.t('external_data_tooltip') | ||
| getDisclaimerPopupContent() { | ||
| return this.$i18n.t('external_data_warning').replace('--URL--', this.AttributionName) |
There was a problem hiding this comment.
Is this string specific to the new viewer? if so I would propose that we use some built-in formatting feature of VueI18N https://kazupon.github.io/vue-i18n/guide/formatting.html#named-formatting
meaning the message in the big spreadsheet can now be ... ... {url} ... ... and the call be this.$i18n.t('external_data_warning', { url: this.AttributionName)}
There was a problem hiding this comment.
That would be great idea however this string is also used by the old viewer.
There was a problem hiding this comment.
Do you think it would be better to duplicate this translation to use the new correct way ?
I propose to do a ticket for this, I would also fixed the following intlify warnings:
[intlify] Detected HTML in 'TESTSITE – DO NOT-SHARE - NOT FOR OPERATIONAL USE<br/>This site is for testing purposes only. It's not meant for operational use and there's no guarantee whatsoever.' message. Recommend not using HTML messages to avoid XSS.shared.esm-bundler.js:54 [intlify] Detected HTML in 'Votre dessin est automatiquement stocké pour une année, vous acceptez ainsi les <a href='https://www.geo.admin.ch/fr/about-swiss-geoportal/impressum.html#drawing ' target='_blank'> conditions d'utilisation</a>.' message. Recommend not using HTML messages to avoid XSS.
davidoesch
left a comment
There was a problem hiding this comment.
Second link: Test link is ok ( it has tooltip in footer and in the logo)
|
Due to bad user experience with tooltip with long text on mobile, this PR is replaced by #362 which use a modal window on click with the big disclaimer text. |
TODO:
--URL--in tooltip by the url.Test link with external layer mf-geoadmin3 syntax
Test link