Merged
Conversation
2448142 to
7009c77
Compare
7009c77 to
711dd45
Compare
davidoesch
reviewed
Jan 19, 2023
Contributor
davidoesch
left a comment
There was a problem hiding this comment.
since this is backward compatible for the existing permalinks... LGTM
2268dab to
d8fb125
Compare
Contributor
711dd45 to
3d1778a
Compare
9a71f57 to
a7df06b
Compare
3d1778a to
e0906fb
Compare
pakb
approved these changes
Jan 25, 2023
Contributor
pakb
left a comment
There was a problem hiding this comment.
Don't know if it is not too cumbersome to achieve, but if you could grab the part of prior commits from #344 that removes src/router/stringifyQuery.js and merge it here so that we have proper refactor action, that would be neat (but that is not mandatory if too complicated)
17f99ab to
35cc121
Compare
e0906fb to
b3f976c
Compare
Base automatically changed from
feat-BGDIINF_SB-2733-drawing-admin-id-part-2
to
develop
January 25, 2023 14:00
b3f976c to
9810333
Compare
Pipe characters are an issue on some external tools like JIRA. Moreover they are not allowed in URL spec.1
9810333 to
5a1d120
Compare
pakb
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://jira.swisstopo.ch/browse/BGDIINF_SB-2750
Test link