Skip to content

Use copy icon for coordinates in position popup#311

Merged
ltshb merged 2 commits intodevelopfrom
copy-icon
Dec 21, 2022
Merged

Use copy icon for coordinates in position popup#311
ltshb merged 2 commits intodevelopfrom
copy-icon

Conversation

@ltshb
Copy link
Contributor

@ltshb ltshb commented Nov 28, 2022

This allow more place for the data and avoid truncating the what3words.

Please give your feedback on the copy icon in the position popup, use the test link below and compare it to the current version in https://sys-map.dev.bgdi.ch

Test link

Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is based on #310 and only the last commit is to be reviewed? If so there it is 😉

@ltshb ltshb force-pushed the copy-icon branch 2 times, most recently from b7d099d to ad597d3 Compare November 29, 2022 12:27
@pakb
Copy link
Contributor

pakb commented Dec 1, 2022

I don't know if we have the right version of TippyJS for what I asked of you with .destroy(), whenever I close a location popup there is now an error in the console.

@ltshb ltshb marked this pull request as draft December 5, 2022 10:07
Copy link
Contributor

@ltkum ltkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good work

Copy link
Contributor

@boecklic boecklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the copy icon. On desktop you have the popover that tells you the action, a mobile user is most likely used to that icon

Copy link
Member

@hansmannj hansmannj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the copy icon.
Probably a stupid question and probably a terrible design faux pas.
Might it make sense to shift the icon slightly to the left, directly following the coordinates?
With the distance in between it's a bit harder to see, which icon belongs to which coordinates.

But probably that looks ugly, and probably I'll don't think this is necessary once I got my new glasses 😉

This allow more place for the data and avoid truncating the what3words.
The tippy constructor returns an array of matched target and therefore we
need to call the destroy to all array element.
@ltshb ltshb marked this pull request as ready for review December 21, 2022 13:45
@ltshb ltshb merged commit 670ed60 into develop Dec 21, 2022
@ltshb ltshb deleted the copy-icon branch December 21, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants