Conversation
ltshb
left a comment
There was a problem hiding this comment.
Very Nice.
I would put the rating before the feedback and let the lazy user give a simple rating, but thats my personal opinion.
|
@pakb When using the
On DEV and INT emails can be seen on the |
that enables the user to rate his experience with a 5 star scale, and write his message directly in the UI (instead of letting him write it in his email editor). Also fixing a bug on tablet layout where the links were not rendered properly in the menu/settings section, as the UI was still considered being in desktop mode, thus the feedback and more info buttons were still rendered as links.
Send feedback to the backend, also simplifying the UI the user uses to send feedback
The user now can see if his request to send a feedback was successful or not, and also cannot send more than once the same feedback (but if he closes the form, he can now start a new feedback)
be04f2f to
a80841c
Compare
|
@pakb I would reduce the max size of the modal window |
|
@pakb the rating preview that you did was quite nice but don't work anymore or did you removed it ? |
|
I tried to simplify it as much as possible as it was on other website. Plus I didn't like that it was pushing the whole stars because they are centered, so the star you clicked wasn't under your cursor anymore. Size : yes I could give a max size for very large screen maybe. I didn't see much issue because I've tested only on small "devices" 😉 |
ltshb
left a comment
There was a problem hiding this comment.
Very nice just some comments
enlarging a little bit the modal component on mobile adding some extra height to the text area in the feedback form changing the fail text to something more specific better handling of error in the process of sending the feedback (KML loading error or short link generation error) changing the feedback API file so that rating (and max rating) are optional, so that we can use the same endpoint in the future for the "Report a problem" feature
e24560a to
eade0b3
Compare
while sending a feedback : fallback to sending full URL if the short link couldn't be generated
|
@pakb The deselect of rating (two click on a star) don't work on iphone, the star stay selected but the send button is then disable. I propose to totally remove the deselect feature as it is not needed. |
ltshb
left a comment
There was a problem hiding this comment.
Just a minor bug on Iphone.
To be honest I would not shorten the url, this url is not used by the user, only by us, and I don't see the advantage of having it shorten. In case of problem report it might even be a disadvantage, as we might need to know the exact url that the user used (we would need to do a curl --head on the short url to get it).
|
That's a good point, although the goal initially was to let the user know that we are going to send this "short permalink" to the service desk, in order to be fully transparent. I've not yet added this line saying "This permalink will be send alongside". I can send the full URL, that would work too yes... |
as there's some CSS glitch on iOS where the colour stays active even when the class "checked" has been removed. Meaning the user has the feeling that something is selected, but the "Send" button is disabled.
that enables the user to rate his experience with a 5 star scale, and write his message directly in the UI (instead of letting him write it in his email editor).
Also fixing a bug on tablet layout where the links were not rendered properly in the menu/settings section, as the UI was still considered being in desktop mode, thus the feedback and more info buttons were still rendered as links.
TODO :
mailTolink system to using the (not yet developped)service-feedbackendpoint to register the ratings/feedbacksTest link