Skip to content

feat_BGDIINF_SB-2666: adding a feedback and link to CMS buttons#358

Merged
pakb merged 1 commit intodevelopfrom
feat_BGDIINF_SB-2666_link_to_cms
Jan 26, 2023
Merged

feat_BGDIINF_SB-2666: adding a feedback and link to CMS buttons#358
pakb merged 1 commit intodevelopfrom
feat_BGDIINF_SB-2666_link_to_cms

Conversation

@procrastinatio
Copy link
Contributor

@procrastinatio procrastinatio commented Jan 25, 2023

See https://jira.swisstopo.ch/browse/BGDIINF_SB-2666 and https://jira.swisstopo.ch/browse/BGDIINF_SB-2674

Please translate the strings, app_feedback_* and cms_link_* accordingly.

Test link

@procrastinatio procrastinatio force-pushed the feat_BGDIINF_SB-2666_link_to_cms branch from cbd62ae to 17807a5 Compare January 25, 2023 17:01
@pakb
Copy link
Contributor

pakb commented Jan 26, 2023

there's also an issue with the "Feedback" button size on mobile
image
you might need to remove some fixed width somewhere

@procrastinatio procrastinatio force-pushed the feat_BGDIINF_SB-2666_link_to_cms branch from 17807a5 to 70505ce Compare January 26, 2023 10:09
@procrastinatio procrastinatio force-pushed the feat_BGDIINF_SB-2666_link_to_cms branch from 70505ce to 04d3557 Compare January 26, 2023 10:26
@pakb
Copy link
Contributor

pakb commented Jan 26, 2023

you can use the key test_map_give_feedback for the "Give feedback" button and cms_link_button_title for the "Information" button

Give the user the opportunity to give a feedback on the application and to get
additional informations about the project (CMS link)
@procrastinatio procrastinatio force-pushed the feat_BGDIINF_SB-2666_link_to_cms branch from 04d3557 to 37cf79f Compare January 26, 2023 11:46
@procrastinatio
Copy link
Contributor Author

OK. translation strings changed et repushed.

@procrastinatio procrastinatio requested a review from pakb January 26, 2023 11:47
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pakb pakb merged commit 41b053b into develop Jan 26, 2023
@pakb pakb deleted the feat_BGDIINF_SB-2666_link_to_cms branch January 26, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants