Skip to content

New Release v1.52.0 - #minor#1245

Merged
pakb merged 58 commits intomasterfrom
develop
Feb 17, 2025
Merged

New Release v1.52.0 - #minor#1245
pakb merged 58 commits intomasterfrom
develop

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented Feb 17, 2025

sommerfe and others added 30 commits January 22, 2025 13:43
…-pre-loaded-kml

PB-1299, PB-1344: Opening Drawing module with pre-loaded empty KML breaks the drawing module
Github link now leads to the release notes
- The github icon link redirects to the repository
- The app version link redirects to the release IF this is a clean version, otherwise it leads to the repository
…-click

PB-1004: Drawing polygone - Move delete point to right click
…ernal-layer-cut

PB-1322: Compare slider external layer not correctly cut after reloading
in prep work to the elevation profile module, I started modularizing what will be used by both the viewer and the future elevation profile component.

I used the opportunity of having a smaller scoped project to switch to Typescript entirely all the utilities.
Migration to ESLint9 was also done here, meaning there are some changes because of new linter rules. Some ESLint8 plugins weren't available in ESLint9 so I had to find equivalents, but they don't have exactly the same way of linting

as we are running a preview on a "from scratch" CI instance, geoadmin package has never been built (and added to the local npm registry for that matter).
Building the lib with the same target in mind before running the preview script on the viewer
Switch to Chrome for CI testing (too many issues with external layer loading and Electron)

Allow clipboard use by default with Chrome on the CI

Refactor Cypress test to gather all intercept logic in one place, shared among all tests
Allow for using a list of nodes for the selector of tippy. This lets us
narrow in the selection of the DOM elements that tippy should initialize
on
Waiting in Cypress so that the tooltips are being removed on cypress.io
The map function directly called transformLayerIntoUrlString. Since the
map function provides three arguments: element, index & array, these
were mapped to the arguments of transformLayerIntoUrlString, with the
third being the parameter `featureIds`, resulting in a weird URL
Reducing a race condition with the visibility of the external test wmts layers
PB-1384 : modularize proj, number and coordinate utils
- use of the new useTemplateRef when applicable (when linking element from the template)
- rework all props to refs logic to match Vue doc https://vuejs.org/guide/components/props.html#reactive-props-destructure
- rework TippyJS composable to be able to receive template ref directly, and be able to receive an array of content. This makes it possible to configure it only through JS params, removing the need for the custom data-tippy-content HTML attribute (and makes the Tippy composable a bit more reactive too)

Also moving any remaining Option API component to the Composition API notation.
pakb and others added 23 commits February 14, 2025 07:42
This was necessary so that I could move the coordinate utils and number utils, whilst having the projection definition as a module.
As coordinate utils is using some of proj definition, I thought it would make more sense to create a big "coordinates" module that do all things related coordinates (proj, transformation etc...)
modules were built in an alphabetical order, failing on CI (from scratch) because some "later" modules needed '@geoadmin/utils'.
So while we wait for pnpm migration (which might fix this issue) I've declared explicitly every workspace of our project, in the order they should be built so that no missing lib error should occur on CI.
I created a task to work on this flaky test case later
PB-1384 : split geoadmin modules into individual modules
Please refer to PR #1224 for original git history and review
…tively-final

PB-1318 : added kml deletion modification with new mapviewer structure
Issue : Some people expressed that removing the zoom buttons on mobile was an issue for them, either regarding the hardware they are using or because of outside issues which stopped them from using the mapviewer correctly.

Fix : We bring the zoom buttons back.
@github-actions github-actions bot changed the title new version New Release v1.52.0 - #minor Feb 17, 2025
@pakb pakb requested review from ltkum and schtibe February 17, 2025 06:46
@pakb pakb merged commit 322ffd6 into master Feb 17, 2025
8 checks passed
@cypress
Copy link

cypress bot commented Feb 17, 2025

web-mapviewer    Run #4576

Run Properties:  status check passed Passed #4576  •  git commit 322ffd6ee7: Merge pull request #1245 from geoadmin/develop
Project web-mapviewer
Branch Review master
Run status status check passed Passed #4576
Run duration 01m 38s
Commit git commit 322ffd6ee7: Merge pull request #1245 from geoadmin/develop
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants