PB-1318 : added kml deletion modification with new mapviewer structure#1231
Merged
sami-nouidri-swisstopo merged 13 commits intodevelopfrom Feb 14, 2025
Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 39s |
| Commit |
|
| Committer | Sami Nouidri |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
6a858e8 to
25fe3f9
Compare
pakb
approved these changes
Feb 14, 2025
Contributor
pakb
left a comment
There was a problem hiding this comment.
You have some linter issues
> lint:no-fix
> eslint
/codebuild/output/src1057/src/github.com/geoadmin/web-mapviewer/packages/mapviewer/src/modules/drawing/components/DrawingToolbox.vue
188:47 error 'class' should be on a new line vue/max-attributes-per-line
191:21 warning Disallow self-closing on HTML void elements (<input/>) vue/html-self-closing
257:44 error 'class' should be on a new line vue/max-attributes-per-line
283:57 error 'class' should be on a new line vue/max-attributes-per-line
295:39 error 'class' should be on a new line vue/max-attributes-per-line
328:60 error '@accept' should be on a new line vue/max-attributes-per-line
✖ 6 problems (5 errors, 1 warning)
5 errors and 1 warning potentially fixable with the `--fix` option.
Maybe check that your VS Code is running eslint --fix after each save (see https://www.digitalocean.com/community/tutorials/workflow-auto-eslinting#step-4-adding-code-actions-on-save )
| expect(layers).to.be.an('Array').and.to.have.length(0) | ||
| }) | ||
|
|
||
| cy.get(`[data-cy^="button-remove-layer-"]`).should('not.exist') |
Contributor
There was a problem hiding this comment.
you don't specify any layer ID here (it ends abruptly at remove-layer-... is it wanted?
added 9 commits
February 14, 2025 09:07
Please refer to PR #1224 for original git history and review
20ecf89 to
d66006e
Compare
e04b992 to
9694752
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KML deletion is now done by sending a request to the pre-existing DELETE route in the service-kml backend.
The original is here : #1224
Test link