PB-1318 : delete KML definitively#1224
Closed
sami-nouidri-swisstopo wants to merge 6 commits intodevelopfrom
Closed
PB-1318 : delete KML definitively#1224sami-nouidri-swisstopo wants to merge 6 commits intodevelopfrom
sami-nouidri-swisstopo wants to merge 6 commits intodevelopfrom
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
task-PB-1318-delete-kml
|
| Run status |
|
| Run duration | 05m 49s |
| Commit |
|
| Committer | Sami Nouidri |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
232
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
tests/cypress/tests-e2e/drawing.cy.js • 1 failed test • e2e/electron/mobile
| Test | Artifacts | |
|---|---|---|
| Drawing module tests > Drawing mode/tools > can create marker/icons and edit them |
Test Replay
Screenshots
|
|
added 4 commits
January 30, 2025 14:15
The functions 'deleteDrawing()' and 'deleteKml' have been added to fully delete the kml, using the existing DELETE route. A back-end URL override has been added for service-kml as well, although it doesn't seem to work for now.
b405cda to
882de5f
Compare
ltkum
reviewed
Jan 31, 2025
Contributor
ltkum
left a comment
There was a problem hiding this comment.
A few things to change, but otherwise looks good.
$
Outdated
| # modified: src/utils/components/DropdownButton.vue | ||
| # modified: tests/cypress/tests-e2e/drawing.cy.js | ||
| # modified: tests/cypress/tests-e2e/reportProblem.cy.js | ||
| # |
Contributor
There was a problem hiding this comment.
this looks like this file is the result of a stdout to a file, and also looks like it's not the correct branch / PR. I would remove that.
src/api/files.api.js
Outdated
| * @returns {Promise<void>} | ||
| */ | ||
| export const deleteKml = (id, adminId) => { | ||
| log.info('base url : ', kmlBaseUrl) |
Contributor
There was a problem hiding this comment.
This looks like a developement log which stayed in the code. You should remove this.
ltkum
approved these changes
Feb 3, 2025
| 201, | ||
| kmlMetadataTemplate({ | ||
| id: `${randomIntBetween(1000, 9999)}_fileId`, | ||
| id: `${Date.now()}_${randomIntBetween(1000, 9999)}_fileId`, |
sami-nouidri-swisstopo
pushed a commit
that referenced
this pull request
Feb 5, 2025
…erarchy Please refer to PR #1224 to view the original git history and review
Contributor
Author
|
As the map viewer has been refactored as part of the modularization effort, the changes have been manually rebased here : #1230 |
sami-nouidri-swisstopo
pushed a commit
that referenced
this pull request
Feb 6, 2025
…erarchy Please refer to PR #1224 to view the original git history and review
sami-nouidri-swisstopo
pushed a commit
that referenced
this pull request
Feb 7, 2025
Please refer to PR #1224 for original git history and review
sami-nouidri-swisstopo
pushed a commit
that referenced
this pull request
Feb 12, 2025
sami-nouidri-swisstopo
pushed a commit
that referenced
this pull request
Feb 13, 2025
Please refer to PR #1224 for original git history and review
sami-nouidri-swisstopo
pushed a commit
that referenced
this pull request
Feb 14, 2025
Please refer to PR #1224 for original git history and review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KML deletion is now done by sending a request to the pre-existing DELETE route in the service-kml backend.
Test link