PB-1428 : complete migration to Vue 3.5#1233
Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
v1.52.0-beta.14
|
| Run status |
|
| Run duration | 01m 38s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
f26a958 to
96fe59e
Compare
schtibe
approved these changes
Feb 10, 2025
| function getImageStrokeStyle(isColorable, isSelected, color) { | ||
| if (isColorable) { | ||
| return { | ||
| filter: `drop-shadow(1px 1px 0 ${color.border}) drop-shadow(-1px -1px 0 ${color.border})`, |
Contributor
There was a problem hiding this comment.
You know you can also return it as a list IIRC, and vue will put it together in the :style attribute. To me this usually seems a bit more graceful than concating strings, but it's surely just a matter of style
| @@ -22,7 +23,7 @@ import { calculateTextOffset } from '@/utils/featureStyleUtils' | |||
|
|
|||
| const dispatcher = { dispatcher: 'FeatureStyleEdit.vue' } | |||
Contributor
There was a problem hiding this comment.
Maybe use upper case here to connotate this as being a "true" constant? It had me confused further down the code
packages/mapviewer/src/modules/infobox/components/FeatureEdit.vue
Outdated
Show resolved
Hide resolved
packages/mapviewer/src/modules/infobox/components/FeatureElevationProfileInformation.vue
Outdated
Show resolved
Hide resolved
|
|
||
| // 2. Put all the props (input) | ||
| const props = defineProps({ | ||
| const { myProp } = defineProps({ |
Contributor
There was a problem hiding this comment.
Unrelated to your change: we haven't specified where to put injects.
- use of the new useTemplateRef when applicable (when linking element from the template) - rework all props to refs logic to match Vue doc https://vuejs.org/guide/components/props.html#reactive-props-destructure - rework TippyJS composable to be able to receive template ref directly, and be able to receive an array of content. This makes it possible to configure it only through JS params, removing the need for the custom data-tippy-content HTML attribute (and makes the Tippy composable a bit more reactive too) Also moving any remaining Option API component to the Composition API notation.
506e0d9 to
2777db0
Compare
2777db0 to
16f53ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also moving any remaining Option API component to the Composition API notation.
Test link