PB-1384 : modularize proj, number and coordinate utils#1227
Merged
Conversation
Contributor
Author
|
CI said Edit: switched to the next tier of virtual hardware for our CI |
31c921a to
9251368
Compare
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-1384-profile-npm-modules
|
| Run status |
|
| Run duration | 03m 46s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
234
|
| View all changes introduced in this branch ↗︎ | |
schtibe
reviewed
Feb 3, 2025
| @@ -1,8 +1,8 @@ | |||
| import { expect } from 'chai' | |||
| import { reprojectAndRound } from 'geoadmin/coordinates' | |||
Contributor
There was a problem hiding this comment.
Should this file go to the other package?
Contributor
There was a problem hiding this comment.
yeah sorry, I mean this test file, not the line.
Contributor
Author
There was a problem hiding this comment.
extentUtils wasn't moved yet, so let's keep the test file with its "parent"
packages/mapviewer/src/modules/menu/components/debug/DebugLayerFinder.vue
Show resolved
Hide resolved
d572384 to
c8595d4
Compare
9084c8b to
4db64c2
Compare
in prep work to the elevation profile module, I started modularizing what will be used by both the viewer and the future elevation profile component. I used the opportunity of having a smaller scoped project to switch to Typescript entirely all the utilities. Migration to ESLint9 was also done here, meaning there are some changes because of new linter rules. Some ESLint8 plugins weren't available in ESLint9 so I had to find equivalents, but they don't have exactly the same way of linting as we are running a preview on a "from scratch" CI instance, geoadmin package has never been built (and added to the local npm registry for that matter). Building the lib with the same target in mind before running the preview script on the viewer
Switch to Chrome for CI testing (too many issues with external layer loading and Electron) Allow clipboard use by default with Chrome on the CI Refactor Cypress test to gather all intercept logic in one place, shared among all tests
Allow for using a list of nodes for the selector of tippy. This lets us narrow in the selection of the DOM elements that tippy should initialize on
Waiting in Cypress so that the tooltips are being removed on cypress.io
The map function directly called transformLayerIntoUrlString. Since the map function provides three arguments: element, index & array, these were mapped to the arguments of transformLayerIntoUrlString, with the third being the parameter `featureIds`, resulting in a weird URL
Reducing a race condition with the visibility of the external test wmts layers
4db64c2 to
ba5936e
Compare
schtibe
approved these changes
Feb 7, 2025
| "vue": "^3.5.13", | ||
| "vue-i18n": "^11.1.0" | ||
| }, | ||
| "devDependencies": { |
Contributor
There was a problem hiding this comment.
Is all this still needed on this level?
Contributor
Author
There was a problem hiding this comment.
I wanted to make sure we are using the same Vue and Vue-i18n version across all packages (I'll start exporting Vue component in the next PR)
| // to avoid additional memory usage by passing the --disable-gl-drawing-for-tests flag. | ||
| launchOptions.args.push('--disable-gl-drawing-for-tests') | ||
| // to avoid additional memory usage by passing the --disable-webgl flag. | ||
| launchOptions.args.push('--disable-webgl') |
Contributor
Author
There was a problem hiding this comment.
should be, we could try removing it and see what happens...
| "jsdom": "^26.0.0", | ||
| "mime-types": "^2.1.35", | ||
| "mocha-junit-reporter": "^2.2.1", | ||
| "rimraf": "^6.0.1", |
Contributor
There was a problem hiding this comment.
Maybe at some point we could do some cleanup with the dependencies? I quickly searched rimraf in the repo and didn't find any user of this, like no import or anything.
Contributor
Author
There was a problem hiding this comment.
it's used to delete JUnit test reports in an agnostic way (so that we may also have people developing on win11 for instance)
a3af156 to
f5c06c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in prep work to the elevation profile module, I started modularizing what will be used by both the viewer and the future elevation profile component.
I used the opportunity of having a smaller scoped project to switch to Typescript entirely all the utilities. Migration to ESLint9 was also done here, meaning there are some changes because of new linter rules. Some ESLint8 plugins weren't available in ESLint9 so I had to find equivalents, but they don't have exactly the same way of linting
Test link