PB-1384 : split geoadmin modules into individual modules#1236
Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 40s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
f09843c to
1e22d19
Compare
This was necessary so that I could move the coordinate utils and number utils, whilst having the projection definition as a module. As coordinate utils is using some of proj definition, I thought it would make more sense to create a big "coordinates" module that do all things related coordinates (proj, transformation etc...)
modules were built in an alphabetical order, failing on CI (from scratch) because some "later" modules needed '@geoadmin/utils'. So while we wait for pnpm migration (which might fix this issue) I've declared explicitly every workspace of our project, in the order they should be built so that no missing lib error should occur on CI.
1e22d19 to
f57199d
Compare
I created a task to work on this flaky test case later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was necessary so that I could move the coordinate utils and number utils, whilst having the projection definition as a module. As coordinate utils is using some of proj definition, I thought it would make more sense to create a big "coordinates" module that do all things related coordinates (proj, transformation etc...)
Test link