Fixes getUniformX for Vulkan by walley892 · Pull Request #181286 · flutter/flutter

walley892 · 2026-01-21T21:20:21Z

Does what it says on the tin!

This PR adds struct member information to the runtime flatbuffer format. This allows dart code to introspect structs at runtime.

Also modifies the runtime_stage tests to verify formats for all supported uniform types.

Bubbles up struct member information to dart, and uses that information to grab struct members in getUniformX related functions. This is necessary on Vulkan because all uniforms are packaged into a single struct. Also re-enables tests

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

gemini-code-assist

Code Review

This pull request adds support for reflecting struct member information for Vulkan uniforms, which is necessary because Vulkan packages all uniforms into a single struct. The changes correctly bubble up this information from the shader compiler to the Dart UI layer, enabling getUniformX functions to work with struct members. The tests have also been updated and re-enabled to cover this new functionality. My review includes suggestions to improve efficiency and maintainability by reducing code duplication and unnecessary copies, and to strengthen test assertions.

gaaclarke

Approach is looking, nice detective work. Do we want to increment RuntimeStagesFormatVersion then?

gaaclarke

Looking good, there is still the open question though about wether we want to bump the version number now.

walley892 · 2026-01-26T23:00:53Z

Looking good, there is still the open question though about wether we want to bump the version number now.

The versioning was introduced in #175470. There are a few PRs linked there that propose to actually use this versioning to allow for shipping precompiled shaders, but none have landed. #175479, #166944, #168294.

Without this info in the flatbuffers, none of the getUniformX will work on Vulkan.

Bumping!

gaaclarke

lgtm, thanks mr wally892

Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions) flutter/flutter@da72d59...1d9d6a9 2026-01-30 planetmarshall@users.noreply.github.com enable enhanced debugging for GLES playground (flutter/flutter#181157) 2026-01-30 matt.kosarek@canonical.com Make the Windows windowing_test in .ci.yaml have bringup as false (flutter/flutter#181664) 2026-01-30 engine-flutter-autoroll@skia.org Roll Packages from cd4fd61 to 510dd40 (4 revisions) (flutter/flutter#181726) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from edbf7e9eb846 to 4745eb2fe837 (1 revision) (flutter/flutter#181725) 2026-01-30 kazbek.sultanov.doc@gmail.com Enhance error handling of WidgetsBindingObserver callbacks (flutter/flutter#181174) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from 05d3cb9d2be9 to edbf7e9eb846 (2 revisions) (flutter/flutter#181715) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from c198e5fa9cd9 to 05d3cb9d2be9 (1 revision) (flutter/flutter#181712) 2026-01-30 engine-flutter-autoroll@skia.org Roll Dart SDK from 920b7e24583e to 2703fd9733ce (2 revisions) (flutter/flutter#181693) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from b9f40c193e7a to c198e5fa9cd9 (6 revisions) (flutter/flutter#181692) 2026-01-30 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181690) 2026-01-30 jason-simmons@users.noreply.github.com Extend the Windows tool_integration_tests_2_9 shard timeout to 1 hour (flutter/flutter#181678) 2026-01-29 34871572+gmackall@users.noreply.github.com Add `android_sdk` dependency to `android_engine_opengles_tests` (flutter/flutter#181681) 2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a0685c8e946b to 920b7e24583e (3 revisions) (flutter/flutter#181680) 2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 128b5213711e to b9f40c193e7a (14 revisions) (flutter/flutter#181675) 2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Ensure that HostBuffers/DeviceBuffers allocated by RendererTest tests are valid for the lifetime of the RenderPass (flutter/flutter#181635) 2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Fix off-by-one indices in the SimilarPointPair/SimilarPointTrio functions used by ShadowPathGeometryTest (flutter/flutter#181623) 2026-01-29 anishtiwari5077@gmail.com 180162 fix radio list tile and switch list tile accept widget states controller (flutter/flutter#180367) 2026-01-29 116356835+AbdeMohlbi@users.noreply.github.com Remove unused test file (flutter/flutter#181671) 2026-01-29 jason-simmons@users.noreply.github.com Roll libpng to version 1.6.54 (flutter/flutter#181625) 2026-01-29 34871572+gmackall@users.noreply.github.com Remove nonstandard ndkpath for `hybrid_android_views` integration test (flutter/flutter#181666) 2026-01-29 34465683+rkishan516@users.noreply.github.com Add TestWidgetsApp utility and refactor widget tests to use WidgetsApp (flutter/flutter#180456) 2026-01-29 rmolivares@renzo-olivares.dev Add `TestTextField` and migrate tests (flutter/flutter#180494) 2026-01-29 jacksongardner@google.com Merge changelog for 3.38.9 (flutter/flutter#181668) 2026-01-29 dacoharkes@google.com [flutter_tools] Deprecate `plugin_ffi` template (flutter/flutter#181588) 2026-01-29 brackenavaron@gmail.com Deprecate onReorder callback (flutter/flutter#178242) 2026-01-29 zhongliu88889@gmail.com [web] Use defensive null check in text editing placeElement (flutter/flutter#180795) 2026-01-29 engine-flutter-autoroll@skia.org Roll Packages from 1cb2148 to cd4fd61 (4 revisions) (flutter/flutter#181663) 2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 89df65f8324c to 128b5213711e (2 revisions) (flutter/flutter#181651) 2026-01-29 dacoharkes@google.com [hooks] Don't run build hooks for code assets in `flutter run` (flutter/flutter#181542) 2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from f10dcbfca98f to a0685c8e946b (5 revisions) (flutter/flutter#181653) 2026-01-29 evanwall@buffalo.edu Fixes getUniformX for Vulkan (flutter/flutter#181286) 2026-01-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from adhoq9ouVRh0xzkm3... to isy1ARvK-3bsvtfc-... (flutter/flutter#181641) 2026-01-29 dmytro@turskyi.com Add isDark, isLight, and isSystem getters to ThemeMode (flutter/flutter#181475) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

Does what it says on the tin! This PR adds struct member information to the runtime flatbuffer format. This allows dart code to introspect structs at runtime. Also modifies the runtime_stage tests to verify formats for all supported uniform types. Bubbles up struct member information to dart, and uses that information to grab struct members in `getUniformX` related functions. This is necessary on Vulkan because all uniforms are packaged into a single struct. Also re-enables tests ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing.

Does what it says on the tin! This PR adds struct member information to the runtime flatbuffer format. This allows dart code to introspect structs at runtime. Also modifies the runtime_stage tests to verify formats for all supported uniform types. Bubbles up struct member information to dart, and uses that information to grab struct members in `getUniformX` related functions. This is necessary on Vulkan because all uniforms are packaged into a single struct. Also re-enables tests - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing.

Reland `Enabled some disabled impeller fragment shader dart tests` (flutter#180788) relands flutter#180759 changes since revert: 1) waits for async tests now 1) keeps 2 tests that don't pass on impeller disabled - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Enables fragment shader test for impeller (fixes mat2 on vulkan) (flutter#181013) This rearranges the packing of mat2 fields in structs which was causing an existing fragment shader test to fail. The test still doesn't work on Metal, but this PR fixes it for Vulkan. I suspect the fix for metal may be similar but since the uniforms aren't in a virtual struct the code isn't hitting this fix. issue: flutter#180873 - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Account for vec3 padding in Metal (flutter#181563) Re-landing of flutter#181340 incorporating flutter#181550. Vec3 uniforms on the metal backend are vec4-aligned. This PR accounts for that padding. --------- Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com> Fixes getUniformX for Vulkan (flutter#181286) Does what it says on the tin! This PR adds struct member information to the runtime flatbuffer format. This allows dart code to introspect structs at runtime. Also modifies the runtime_stage tests to verify formats for all supported uniform types. Bubbles up struct member information to dart, and uses that information to grab struct members in `getUniformX` related functions. This is necessary on Vulkan because all uniforms are packaged into a single struct. Also re-enables tests - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. Organize and update fragment shader uniform tests. (flutter#181822) Adds more comprehensive testing for setFloat and getUniform* on fragment shaders. Deletes redundant tests. Fixes getUniformVecX indexing errors. Update web ui fragment shader tests (flutter#181877) Adds a bunch of tests for uniform setting functionality for custom fragment shaders on the web. Deletes redundant tests. Fixes a discovered issue in the uniform offset calculation. We were previously using the `location`, which is the integer offset of the uniform, not the offset in floats.

Does what it says on the tin! This PR adds struct member information to the runtime flatbuffer format. This allows dart code to introspect structs at runtime. Also modifies the runtime_stage tests to verify formats for all supported uniform types. Bubbles up struct member information to dart, and uses that information to grab struct members in `getUniformX` related functions. This is necessary on Vulkan because all uniforms are packaged into a single struct. Also re-enables tests ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing.

…r#10931) Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions) flutter/flutter@da72d59...1d9d6a9 2026-01-30 planetmarshall@users.noreply.github.com enable enhanced debugging for GLES playground (flutter/flutter#181157) 2026-01-30 matt.kosarek@canonical.com Make the Windows windowing_test in .ci.yaml have bringup as false (flutter/flutter#181664) 2026-01-30 engine-flutter-autoroll@skia.org Roll Packages from cd4fd61 to 510dd40 (4 revisions) (flutter/flutter#181726) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from edbf7e9eb846 to 4745eb2fe837 (1 revision) (flutter/flutter#181725) 2026-01-30 kazbek.sultanov.doc@gmail.com Enhance error handling of WidgetsBindingObserver callbacks (flutter/flutter#181174) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from 05d3cb9d2be9 to edbf7e9eb846 (2 revisions) (flutter/flutter#181715) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from c198e5fa9cd9 to 05d3cb9d2be9 (1 revision) (flutter/flutter#181712) 2026-01-30 engine-flutter-autoroll@skia.org Roll Dart SDK from 920b7e24583e to 2703fd9733ce (2 revisions) (flutter/flutter#181693) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from b9f40c193e7a to c198e5fa9cd9 (6 revisions) (flutter/flutter#181692) 2026-01-30 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181690) 2026-01-30 jason-simmons@users.noreply.github.com Extend the Windows tool_integration_tests_2_9 shard timeout to 1 hour (flutter/flutter#181678) 2026-01-29 34871572+gmackall@users.noreply.github.com Add `android_sdk` dependency to `android_engine_opengles_tests` (flutter/flutter#181681) 2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a0685c8e946b to 920b7e24583e (3 revisions) (flutter/flutter#181680) 2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 128b5213711e to b9f40c193e7a (14 revisions) (flutter/flutter#181675) 2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Ensure that HostBuffers/DeviceBuffers allocated by RendererTest tests are valid for the lifetime of the RenderPass (flutter/flutter#181635) 2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Fix off-by-one indices in the SimilarPointPair/SimilarPointTrio functions used by ShadowPathGeometryTest (flutter/flutter#181623) 2026-01-29 anishtiwari5077@gmail.com 180162 fix radio list tile and switch list tile accept widget states controller (flutter/flutter#180367) 2026-01-29 116356835+AbdeMohlbi@users.noreply.github.com Remove unused test file (flutter/flutter#181671) 2026-01-29 jason-simmons@users.noreply.github.com Roll libpng to version 1.6.54 (flutter/flutter#181625) 2026-01-29 34871572+gmackall@users.noreply.github.com Remove nonstandard ndkpath for `hybrid_android_views` integration test (flutter/flutter#181666) 2026-01-29 34465683+rkishan516@users.noreply.github.com Add TestWidgetsApp utility and refactor widget tests to use WidgetsApp (flutter/flutter#180456) 2026-01-29 rmolivares@renzo-olivares.dev Add `TestTextField` and migrate tests (flutter/flutter#180494) 2026-01-29 jacksongardner@google.com Merge changelog for 3.38.9 (flutter/flutter#181668) 2026-01-29 dacoharkes@google.com [flutter_tools] Deprecate `plugin_ffi` template (flutter/flutter#181588) 2026-01-29 brackenavaron@gmail.com Deprecate onReorder callback (flutter/flutter#178242) 2026-01-29 zhongliu88889@gmail.com [web] Use defensive null check in text editing placeElement (flutter/flutter#180795) 2026-01-29 engine-flutter-autoroll@skia.org Roll Packages from 1cb2148 to cd4fd61 (4 revisions) (flutter/flutter#181663) 2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 89df65f8324c to 128b5213711e (2 revisions) (flutter/flutter#181651) 2026-01-29 dacoharkes@google.com [hooks] Don't run build hooks for code assets in `flutter run` (flutter/flutter#181542) 2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from f10dcbfca98f to a0685c8e946b (5 revisions) (flutter/flutter#181653) 2026-01-29 evanwall@buffalo.edu Fixes getUniformX for Vulkan (flutter/flutter#181286) 2026-01-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from adhoq9ouVRh0xzkm3... to isy1ARvK-3bsvtfc-... (flutter/flutter#181641) 2026-01-29 dmytro@turskyi.com Add isDark, isLight, and isSystem getters to ThemeMode (flutter/flutter#181475) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

walley892 added 2 commits January 21, 2026 12:42

Surface struct information from impellerc

1971c50

Fix getUniformX for Vulkan, re-enable tests

2d2b58e

walley892 requested a review from gaaclarke January 21, 2026 21:20

github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 21, 2026

walley892 mentioned this pull request Jan 21, 2026

Surface struct member information from impellerc #181285

Closed

9 tasks

gemini-code-assist Bot reviewed Jan 21, 2026

View reviewed changes

walley892 added 2 commits January 21, 2026 13:40

bot comments

71ea3fe

static cast

beeed7e

gaaclarke requested changes Jan 22, 2026

View reviewed changes

human comments

753d5c8

walley892 requested a review from gaaclarke January 22, 2026 20:47

gaaclarke reviewed Jan 22, 2026

View reviewed changes

walley892 added 2 commits January 23, 2026 13:23

bump flatbuffer format version

acac352

Merge remote-tracking branch 'upstream/master' into get-uniform-vulkan

82d18dc

walley892 requested a review from gaaclarke January 23, 2026 21:27

walley892 added 2 commits January 23, 2026 15:15

Update mat2 layout after padding change

0965396

Format

e3b49df

gaaclarke approved these changes Jan 26, 2026

View reviewed changes

walley892 added 2 commits January 26, 2026 15:53

Merge remote-tracking branch 'upstream/master' into get-uniform-vulkan

89000ea

Fix tests after merge

4a240bd

walley892 mentioned this pull request Jan 27, 2026

Fragment Shader getUniform Tests fail with Metal backend on Linux #181562

Open

walley892 added 3 commits January 28, 2026 13:38

Merge remote-tracking branch 'upstream/master' into get-uniform-vulkan

847703b

Re enable tests for Vulkan

6451eae

Merge remote-tracking branch 'upstream/master' into get-uniform-vulkan

beb2e23

walley892 added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2026

auto-submit Bot added this pull request to the merge queue Jan 29, 2026

Merged via the queue into flutter:master with commit d2d872c Jan 29, 2026
182 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2026

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026

d2d872c95 Fixes getUniformX for Vulkan (flutter/flutter#181286)

1744a19

engine-flutter-autoroll mentioned this pull request Jan 30, 2026

Roll Flutter from da72d5936d69 to 32aef9f3e2e1 (29 revisions) flutter/packages#10927

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026

d2d872c95 Fixes getUniformX for Vulkan (flutter/flutter#181286)

f21c058

engine-flutter-autoroll mentioned this pull request Jan 30, 2026

Roll Flutter from da72d5936d69 to d06ccc562780 (30 revisions) flutter/packages#10928

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026

d2d872c95 Fixes getUniformX for Vulkan (flutter/flutter#181286)

b3cddc0

engine-flutter-autoroll mentioned this pull request Jan 30, 2026

Roll Flutter from da72d5936d69 to d13d227639b7 (31 revisions) flutter/packages#10929

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026

d2d872c95 Fixes getUniformX for Vulkan (flutter/flutter#181286)

2b8fe5f

engine-flutter-autoroll mentioned this pull request Jan 30, 2026

Roll Flutter from da72d5936d69 to 7323c0ee05a3 (32 revisions) flutter/packages#10930

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026

d2d872c95 Fixes getUniformX for Vulkan (flutter/flutter#181286)

1132a1c

engine-flutter-autoroll mentioned this pull request Jan 30, 2026

Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions) flutter/packages#10931

Merged

walley892 mentioned this pull request Feb 12, 2026

getUniformFloat(String name) fails on Vulkan #180595

Closed

Uh oh!

Conversation

walley892 commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

walley892 commented Jan 26, 2026

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

walley892 commented Jan 21, 2026 •

edited

Loading