Skip to content

180162 fix radio list tile and switch list tile accept widget states controller#180367

Merged
auto-submit[bot] merged 17 commits into
flutter:masterfrom
AnishTiwari5077:180162_fix-RadioListTile-and-SwitchListTile-accept-WidgetStatesController
Jan 29, 2026
Merged

180162 fix radio list tile and switch list tile accept widget states controller#180367
auto-submit[bot] merged 17 commits into
flutter:masterfrom
AnishTiwari5077:180162_fix-RadioListTile-and-SwitchListTile-accept-WidgetStatesController

Conversation

@AnishTiwari5077

@AnishTiwari5077 AnishTiwari5077 commented Dec 29, 2025 •
edited by dkwingsmt
Loading

Copy link
Copy Markdown
Contributor

fixes #180162
RadioListTile, CheckboxListTile, and SwitchListTile accepts a WidgetStatesController for their backing ListTile

@google-cla

google-cla Bot commented Dec 29, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Dec 29, 2025
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Dec 29, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds statesController support to CheckboxListTile, RadioListTile, and SwitchListTile, allowing for external control over their interactive states. The implementation is consistent across all three widgets and includes corresponding tests. However, I've identified an issue in the test for RadioListTile where it doesn't properly verify the intended behavior. A suggestion to fix the test has been provided.

Comment thread packages/flutter/test/material/radio_list_tile_test.dart
@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Dec 30, 2025
@dkwingsmt dkwingsmt requested review from QuncCccccc and removed request for MitchellGoodwin January 28, 2026 19:17
QuncCccccc
QuncCccccc approved these changes Jan 28, 2026
View reviewed changes

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits. Thanks for your contribution:)

Comment thread DEPS Outdated
Comment thread packages/flutter/test/material/switch_list_tile_test.dart
Comment thread packages/flutter/test/material/checkbox_list_tile_test.dart
dkwingsmt
dkwingsmt reviewed Jan 28, 2026
View reviewed changes

@dkwingsmt dkwingsmt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for reverting the change in DEPS

dkwingsmt and others added 2 commits January 28, 2026 14:35
@dkwingsmt
Merge branch 'master' into 180162_fix-RadioListTile-and-SwitchListTil…
4c4bd9a 
…e-accept-WidgetStatesController
@AnishTiwari5077 @QuncCccccc
Apply suggestion from @QuncCccccc
76d8d68 
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
AnishTiwari5077
AnishTiwari5077 commented Jan 29, 2026
View reviewed changes

@AnishTiwari5077 AnishTiwari5077 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert unintended DEPS change

Comment thread DEPS Outdated
],
},
]
] No newline at end of file

@AnishTiwari5077 AnishTiwari5077 Jan 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert unintended DEPS change

dkwingsmt
dkwingsmt reviewed Jan 29, 2026
View reviewed changes
Comment thread DEPS Outdated
@github-actions github-actions Bot removed the engine flutter/engine related. See also e: labels. label Jan 29, 2026
@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Jan 29, 2026
Merged via the queue into flutter:master with commit 1b5b0d7 Jan 29, 2026
72 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2026
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026
@engine-flutter-autoroll
1b5b0d787 180162 fix radio list tile and switch list tile accept widg…
677d44a 
…et states controller (flutter/flutter#180367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026
@engine-flutter-autoroll
1b5b0d787 180162 fix radio list tile and switch list tile accept widg…
6469473 
…et states controller (flutter/flutter#180367)
This was referenced Jan 30, 2026
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026
@engine-flutter-autoroll
1b5b0d787 180162 fix radio list tile and switch list tile accept widg…
1ead7e5 
…et states controller (flutter/flutter#180367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026
@engine-flutter-autoroll
1b5b0d787 180162 fix radio list tile and switch list tile accept widg…
0bdca87 
…et states controller (flutter/flutter#180367)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026
@engine-flutter-autoroll
1b5b0d787 180162 fix radio list tile and switch list tile accept widg…
435a13e 
…et states controller (flutter/flutter#180367)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2026
Merged
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jan 30, 2026
@engine-flutter-autoroll
Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions) (#10931)
837dbbd 
Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions)

flutter/flutter@da72d59...1d9d6a9

2026-01-30 planetmarshall@users.noreply.github.com enable enhanced debugging for GLES playground (flutter/flutter#181157)
2026-01-30 matt.kosarek@canonical.com Make the Windows windowing_test in .ci.yaml have bringup as false (flutter/flutter#181664)
2026-01-30 engine-flutter-autoroll@skia.org Roll Packages from cd4fd61 to 510dd40 (4 revisions) (flutter/flutter#181726)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from edbf7e9eb846 to 4745eb2fe837 (1 revision) (flutter/flutter#181725)
2026-01-30 kazbek.sultanov.doc@gmail.com Enhance error handling of WidgetsBindingObserver callbacks (flutter/flutter#181174)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from 05d3cb9d2be9 to edbf7e9eb846 (2 revisions) (flutter/flutter#181715)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from c198e5fa9cd9 to 05d3cb9d2be9 (1 revision) (flutter/flutter#181712)
2026-01-30 engine-flutter-autoroll@skia.org Roll Dart SDK from 920b7e24583e to 2703fd9733ce (2 revisions) (flutter/flutter#181693)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from b9f40c193e7a to c198e5fa9cd9 (6 revisions) (flutter/flutter#181692)
2026-01-30 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181690)
2026-01-30 jason-simmons@users.noreply.github.com Extend the Windows tool_integration_tests_2_9 shard timeout to 1 hour (flutter/flutter#181678)
2026-01-29 34871572+gmackall@users.noreply.github.com Add `android_sdk` dependency to `android_engine_opengles_tests` (flutter/flutter#181681)
2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a0685c8e946b to 920b7e24583e (3 revisions) (flutter/flutter#181680)
2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 128b5213711e to b9f40c193e7a (14 revisions) (flutter/flutter#181675)
2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Ensure that HostBuffers/DeviceBuffers allocated by RendererTest tests are valid for the lifetime of the RenderPass (flutter/flutter#181635)
2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Fix off-by-one indices in the SimilarPointPair/SimilarPointTrio functions used by ShadowPathGeometryTest (flutter/flutter#181623)
2026-01-29 anishtiwari5077@gmail.com 180162 fix radio list tile and switch list tile accept widget states controller (flutter/flutter#180367)
2026-01-29 116356835+AbdeMohlbi@users.noreply.github.com Remove unused test file (flutter/flutter#181671)
2026-01-29 jason-simmons@users.noreply.github.com Roll libpng to version 1.6.54 (flutter/flutter#181625)
2026-01-29 34871572+gmackall@users.noreply.github.com Remove nonstandard ndkpath for `hybrid_android_views` integration test (flutter/flutter#181666)
2026-01-29 34465683+rkishan516@users.noreply.github.com Add TestWidgetsApp utility and refactor widget tests to use WidgetsApp (flutter/flutter#180456)
2026-01-29 rmolivares@renzo-olivares.dev Add `TestTextField` and migrate tests (flutter/flutter#180494)
2026-01-29 jacksongardner@google.com Merge changelog for 3.38.9 (flutter/flutter#181668)
2026-01-29 dacoharkes@google.com [flutter_tools] Deprecate `plugin_ffi` template (flutter/flutter#181588)
2026-01-29 brackenavaron@gmail.com Deprecate onReorder callback (flutter/flutter#178242)
2026-01-29 zhongliu88889@gmail.com [web] Use defensive null check in text editing placeElement (flutter/flutter#180795)
2026-01-29 engine-flutter-autoroll@skia.org Roll Packages from 1cb2148 to cd4fd61 (4 revisions) (flutter/flutter#181663)
2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 89df65f8324c to 128b5213711e (2 revisions) (flutter/flutter#181651)
2026-01-29 dacoharkes@google.com [hooks] Don't run build hooks for code assets in `flutter run` (flutter/flutter#181542)
2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from f10dcbfca98f to a0685c8e946b (5 revisions) (flutter/flutter#181653)
2026-01-29 evanwall@buffalo.edu Fixes getUniformX for Vulkan (flutter/flutter#181286)
2026-01-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from adhoq9ouVRh0xzkm3... to isy1ARvK-3bsvtfc-... (flutter/flutter#181641)
2026-01-29 dmytro@turskyi.com Add isDark, isLight, and isSystem getters to ThemeMode (flutter/flutter#181475)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
...
@AnishTiwari5077 AnishTiwari5077 deleted the 180162_fix-RadioListTile-and-SwitchListTile-accept-WidgetStatesController branch February 3, 2026 10:59
LongCatIsLooong pushed a commit to LongCatIsLooong/flutter that referenced this pull request Feb 6, 2026
@AnishTiwari5077 @gemini-code-assist
@dkwingsmt @QuncCccccc @LongCatIsLooong
180162 fix radio list tile and switch list tile accept widget states …
6b194b4 
…controller (flutter#180367)

fixes flutter#180162  
RadioListTile, CheckboxListTile, and SwitchListTile accepts a
WidgetStatesController for their backing ListTile

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
@Piinks Piinks mentioned this pull request Feb 6, 2026
Open
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Feb 10, 2026
@AnishTiwari5077 @gemini-code-assist
@dkwingsmt @QuncCccccc @flutter-zl
180162 fix radio list tile and switch list tile accept widget states …
e32bce5 
…controller (flutter#180367)

fixes flutter#180162  
RadioListTile, CheckboxListTile, and SwitchListTile accepts a
WidgetStatesController for their backing ListTile

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
@AnishTiwari5077 @gemini-code-assist
@dkwingsmt @QuncCccccc @rickhohler
180162 fix radio list tile and switch list tile accept widget states …
9adb164 
…controller (flutter#180367)

fixes flutter#180162  
RadioListTile, CheckboxListTile, and SwitchListTile accepts a
WidgetStatesController for their backing ListTile

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions) (flutte…
48bd1c4 
…r#10931)

Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions)

flutter/flutter@da72d59...1d9d6a9

2026-01-30 planetmarshall@users.noreply.github.com enable enhanced debugging for GLES playground (flutter/flutter#181157)
2026-01-30 matt.kosarek@canonical.com Make the Windows windowing_test in .ci.yaml have bringup as false (flutter/flutter#181664)
2026-01-30 engine-flutter-autoroll@skia.org Roll Packages from cd4fd61 to 510dd40 (4 revisions) (flutter/flutter#181726)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from edbf7e9eb846 to 4745eb2fe837 (1 revision) (flutter/flutter#181725)
2026-01-30 kazbek.sultanov.doc@gmail.com Enhance error handling of WidgetsBindingObserver callbacks (flutter/flutter#181174)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from 05d3cb9d2be9 to edbf7e9eb846 (2 revisions) (flutter/flutter#181715)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from c198e5fa9cd9 to 05d3cb9d2be9 (1 revision) (flutter/flutter#181712)
2026-01-30 engine-flutter-autoroll@skia.org Roll Dart SDK from 920b7e24583e to 2703fd9733ce (2 revisions) (flutter/flutter#181693)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from b9f40c193e7a to c198e5fa9cd9 (6 revisions) (flutter/flutter#181692)
2026-01-30 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181690)
2026-01-30 jason-simmons@users.noreply.github.com Extend the Windows tool_integration_tests_2_9 shard timeout to 1 hour (flutter/flutter#181678)
2026-01-29 34871572+gmackall@users.noreply.github.com Add `android_sdk` dependency to `android_engine_opengles_tests` (flutter/flutter#181681)
2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a0685c8e946b to 920b7e24583e (3 revisions) (flutter/flutter#181680)
2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 128b5213711e to b9f40c193e7a (14 revisions) (flutter/flutter#181675)
2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Ensure that HostBuffers/DeviceBuffers allocated by RendererTest tests are valid for the lifetime of the RenderPass (flutter/flutter#181635)
2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Fix off-by-one indices in the SimilarPointPair/SimilarPointTrio functions used by ShadowPathGeometryTest (flutter/flutter#181623)
2026-01-29 anishtiwari5077@gmail.com 180162 fix radio list tile and switch list tile accept widget states controller (flutter/flutter#180367)
2026-01-29 116356835+AbdeMohlbi@users.noreply.github.com Remove unused test file (flutter/flutter#181671)
2026-01-29 jason-simmons@users.noreply.github.com Roll libpng to version 1.6.54 (flutter/flutter#181625)
2026-01-29 34871572+gmackall@users.noreply.github.com Remove nonstandard ndkpath for `hybrid_android_views` integration test (flutter/flutter#181666)
2026-01-29 34465683+rkishan516@users.noreply.github.com Add TestWidgetsApp utility and refactor widget tests to use WidgetsApp (flutter/flutter#180456)
2026-01-29 rmolivares@renzo-olivares.dev Add `TestTextField` and migrate tests (flutter/flutter#180494)
2026-01-29 jacksongardner@google.com Merge changelog for 3.38.9 (flutter/flutter#181668)
2026-01-29 dacoharkes@google.com [flutter_tools] Deprecate `plugin_ffi` template (flutter/flutter#181588)
2026-01-29 brackenavaron@gmail.com Deprecate onReorder callback (flutter/flutter#178242)
2026-01-29 zhongliu88889@gmail.com [web] Use defensive null check in text editing placeElement (flutter/flutter#180795)
2026-01-29 engine-flutter-autoroll@skia.org Roll Packages from 1cb2148 to cd4fd61 (4 revisions) (flutter/flutter#181663)
2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 89df65f8324c to 128b5213711e (2 revisions) (flutter/flutter#181651)
2026-01-29 dacoharkes@google.com [hooks] Don't run build hooks for code assets in `flutter run` (flutter/flutter#181542)
2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from f10dcbfca98f to a0685c8e946b (5 revisions) (flutter/flutter#181653)
2026-01-29 evanwall@buffalo.edu Fixes getUniformX for Vulkan (flutter/flutter#181286)
2026-01-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from adhoq9ouVRh0xzkm3... to isy1ARvK-3bsvtfc-... (flutter/flutter#181641)
2026-01-29 dmytro@turskyi.com Add isDark, isLight, and isSystem getters to ThemeMode (flutter/flutter#181475)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes
@QuncCccccc QuncCccccc QuncCccccc approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RadioListTile, CheckboxListTile, and SwitchListTile should accept a WidgetStatesController for their backing ListTile

3 participants

@AnishTiwari5077 @dkwingsmt @QuncCccccc